Skip to content

Fix undefined timing measurement errors in server context#21201

Open
thedanhoffman wants to merge 1 commit intoggml-org:masterfrom
thedanhoffman:server_slot_timing_undef_fix
Open

Fix undefined timing measurement errors in server context#21201
thedanhoffman wants to merge 1 commit intoggml-org:masterfrom
thedanhoffman:server_slot_timing_undef_fix

Conversation

@thedanhoffman
Copy link
Copy Markdown
Contributor

@thedanhoffman thedanhoffman commented Mar 30, 2026

Overview

Fix UB issue reported by Valgrind involving timing measurements for prompt processing and eval

Additional information

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: I threw an AI at this, but the fix is simple enough that there's no real downside risk (independently verified this solves the issue)

@thedanhoffman thedanhoffman requested a review from a team as a code owner March 30, 2026 22:47
@thedanhoffman thedanhoffman marked this pull request as draft March 30, 2026 23:02
@thedanhoffman thedanhoffman marked this pull request as draft March 30, 2026 23:02
@thedanhoffman
Copy link
Copy Markdown
Contributor Author

Found a few other ones. Moving this draft until those are fixed as well (since this is a pretty small change on its own to merge)

@thedanhoffman thedanhoffman force-pushed the server_slot_timing_undef_fix branch from a50cbc3 to 9f7ce43 Compare March 31, 2026 04:09
@thedanhoffman thedanhoffman marked this pull request as ready for review March 31, 2026 04:22
@thedanhoffman
Copy link
Copy Markdown
Contributor Author

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants