Skip to content

Fix undefined timing measurement errors in server context #21201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedanhoffman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined timing measurement errors in server context #21201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/server/server-context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ struct server_slot {
int64_t t_start_process_prompt;
int64_t t_start_generation;

double t_prompt_processing; // ms
double t_token_generation; // ms
double t_prompt_processing = 0.0; // ms
double t_token_generation = 0.0; // ms

std::function<void(int /* id_slot */)> callback_on_release;

Expand Down
12 changes: 6 additions & 6 deletions tools/server/server-task.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,14 +261,14 @@ struct result_timings {
int32_t cache_n = -1;

int32_t prompt_n = -1;
double prompt_ms;
double prompt_per_token_ms;
double prompt_per_second;
double prompt_ms = 0.0;
double prompt_per_token_ms = 0.0;
double prompt_per_second = 0.0;

int32_t predicted_n = -1;
double predicted_ms;
double predicted_per_token_ms;
double predicted_per_second;
double predicted_ms = 0.0;
double predicted_per_token_ms = 0.0;
double predicted_per_second = 0.0;

// Optional speculative metrics - only included when > 0
int32_t draft_n = 0;
Expand Down