This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Conversation
This should catch issues like #801. This uses the new `tasks` syntax to define multiple Windows tasks: https://github.com/bazelbuild/continuous-integration/blob/master/buildkite/README.md#basic-syntax
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
- Coverage 73.20% 73.13% -0.08%
==========================================
Files 17 17
Lines 3281 2963 -318
==========================================
- Hits 2402 2167 -235
+ Misses 879 796 -83
Continue to review full report at Codecov.
|
Contributor
|
Thanks. Looks great! Only some runners are having a bad day. |
sergiud
approved these changes
Mar 2, 2022
Contributor
|
@drigz You can try amending the latest commit and force push the changes. This should solve Codecov issues. |
I would prefer to fix this in glog.bzl but couldn't get that to work.
drigz
force-pushed
the
new-presubmit-format
branch
from
ae29a93 to
b34ddf6
Compare
Contributor
|
I think we can ignore those macOS runner failure. I'll look into it later. |
Member
Author
|
Thanks for checking. Do you also plan to look at the clang warnings? |
Contributor
|
Yes, I'll look at that too. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should catch issues like #801. This uses the new
taskssyntax todefine multiple Windows tasks:
https://github.com/bazelbuild/continuous-integration/blob/master/buildkite/README.md#basic-syntax
I've removed
/WXto allow warnings because there are quite a few, and I'm not confident enough in my C++ to dig into solving them. https://buildkite.com/bazel/google-logging/builds/2611#8de3f805-297c-484e-a63d-2092e8e49faa