Skip to content

fix(web): Studio wait, non-gate holds, and Act copy - #1694

Closed
groupthinking wants to merge 4 commits into
mainfrom
cursor/studio-axiom-playflow-14b8
Closed

groupthinking wants to merge 4 commits into
mainfrom
cursor/studio-axiom-playflow-14b8

Conversation

@groupthinking

@groupthinking groupthinking commented Sep 8, 2026 •

Copy link
Copy Markdown
Owner

Canonical issue

Follow-up to merged #1692 (Hayden pBsT6v-ciO8 empty-events workbench) and merged #1695 (F: skip/unknown Deploy). CoS kill order: A and F are landed. This PR is B + E only. #1692 stays merged.

Outcome

Keeps honest empty Events (no fake events) and adds:

  1. B Transcript stages 1/3 Pack → 2/3 Transcript → 3/3 Analysis with remaining-time ETA. After the typical 45s wait (or a failed run), Retry transcript is available. Elapsed lives only on Working · Ns.
  2. Architecture/artifacts stay prominent when Named tools is empty.
  3. E Footer CTA is Act on this run; review_action is a proposed finding (Proposed actions).

Rebased onto main after #1695. Skip/unknown stack checks stay the hold source of truth (deployHoldReason(..., 'anonymous')). SeaDance/Cluely stay visible as Unknown; they do not hold Deploy.

Copilot on this PR: export confirmation no longer claims named tools when toolCount is 0; citation fixture is auJzb1D-fag.

Verify after A (live pack)

GET https://uvai.io/api/video/pack?url=https://www.youtube.com/watch?v=pBsT6v-ciO8 → 200: no events field, no pack insights, architecture present, artifacts 2, tools SeaDance/Claude Fable/Character.ai/Cluely, transcript 1767, keyframes 11 / concepts 8 / code_snippets 3. UI Events stay empty; those extras are not mapped into Events. Summary only appears if the workflow later writes selected.insights.

Scope

Risk

Verification

Head SHA: b2611e9ab

Agent handoff

Open in Web Open in Cursor 

Copilot AI balanced review requested due to automatic review settings September 8, 2026 17:02
@github-actions github-actions Bot added documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests labels Sep 8, 2026
@vercel

vercel Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 8, 2026 5:16pm UTC

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA b2611e9.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d813ccf3-359f-4348-90fa-fee4a1ba2422


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Working status duplicates elapsed time, export confirmation can overstate contents, and a test violates the standard fixture convention.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Improves Studio feedback, pack presentation, deploy gating, action labeling, and export messaging.

Changes:

  • Adds live pack/transcript progress and clearer empty/failure states.
  • Restricts deploy holds to Vercel, Shopify, and GitHub checks.
  • Promotes pack tools and proposed actions with focused tests.
File summaries
File Description
apps/web/src/components/OneLoopStudio.tsx Integrates progress, pack tools, deploy gating, and Act copy.
apps/web/src/lib/studio-pipeline-status.ts Adds status, labeling, promotion, and export helpers.
apps/web/src/lib/official-templates.ts Limits deploy-hold stacks.
apps/web/src/lib/__tests__/studio-pipeline-status.test.ts Tests new Studio behavior.
apps/web/src/lib/__tests__/official-templates.test.ts Tests non-gating named tools.
apps/web/src/lib/studio-playflow-PLAN.md Records completed follow-up scope.
Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 3
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

🔍 PR Validation

✅ Current validation passed.

cursoragent and others added 3 commits September 8, 2026 17:15
Failed runs no longer look complete. Tools-only packs render in the
workbench. Pack identity shows while transcript waits. SeaDance/Cluely
named tools do not hold Deploy. review_action is labeled as a proposal.

Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Drop duplicate elapsed from working copy, gate export named-tools
on count, and use the auJzb1D-fag fixture. Show 1/3–3/3 stages
with remaining-time ETA and a Retry control after the typical wait.

Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/studio-axiom-playflow-14b8 branch from 97b3cb8 to f8827b2 Compare September 8, 2026 17:15
Keep the #1695 contract at the call site so unsigned Deploy stays skip, not held.

Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
@kk-agent

kk-agent commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Superseded by UVAI Loop sole-writer Studio playflow cut: A/#1692 + F/#1695 + B/#1700 merged; C–G restack in flight (#1701+). Closing to avoid dual-writer / conflicting OneLoopStudio edits. Re-open only if CoS reassigns.

@kk-agent

kk-agent commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Closed as superseded by Loop B–G path (#1700+).

This branch was successfully deployed

1 active deployment
Preview — b2611e9a Deployed Sep 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants