Repository navigation
fix(web): Studio wait, non-gate holds, and Act copy - #1694
groupthinking wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
Working status duplicates elapsed time, export confirmation can overstate contents, and a test violates the standard fixture convention.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves Studio feedback, pack presentation, deploy gating, action labeling, and export messaging.
Changes:
- Adds live pack/transcript progress and clearer empty/failure states.
- Restricts deploy holds to Vercel, Shopify, and GitHub checks.
- Promotes pack tools and proposed actions with focused tests.
File summaries
| File | Description |
|---|---|
apps/web/src/components/OneLoopStudio.tsx |
Integrates progress, pack tools, deploy gating, and Act copy. |
apps/web/src/lib/studio-pipeline-status.ts |
Adds status, labeling, promotion, and export helpers. |
apps/web/src/lib/official-templates.ts |
Limits deploy-hold stacks. |
apps/web/src/lib/__tests__/studio-pipeline-status.test.ts |
Tests new Studio behavior. |
apps/web/src/lib/__tests__/official-templates.test.ts |
Tests non-gating named tools. |
apps/web/src/lib/studio-playflow-PLAN.md |
Records completed follow-up scope. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🔍 PR Validation✅ Current validation passed. |
Failed runs no longer look complete. Tools-only packs render in the workbench. Pack identity shows while transcript waits. SeaDance/Cluely named tools do not hold Deploy. review_action is labeled as a proposal. Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Drop duplicate elapsed from working copy, gate export named-tools on count, and use the auJzb1D-fag fixture. Show 1/3–3/3 stages with remaining-time ETA and a Retry control after the typical wait. Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
97b3cb8 to
f8827b2
Compare
Keep the #1695 contract at the call site so unsigned Deploy stays skip, not held. Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
|
Closed as superseded by Loop B–G path (#1700+). |
Canonical issue
Follow-up to merged #1692 (Hayden
pBsT6v-ciO8empty-events workbench) and merged #1695 (F: skip/unknown Deploy). CoS kill order: A and F are landed. This PR is B + E only. #1692 stays merged.Outcome
Keeps honest empty Events (no fake events) and adds:
1/3 Pack → 2/3 Transcript → 3/3 Analysiswith remaining-time ETA. After the typical 45s wait (or a failed run), Retry transcript is available. Elapsed lives only onWorking · Ns.review_actionis a proposed finding (Proposed actions).Rebased onto
mainafter #1695. Skip/unknown stack checks stay the hold source of truth (deployHoldReason(..., 'anonymous')). SeaDance/Cluely stay visible as Unknown; they do not hold Deploy.Copilot on this PR: export confirmation no longer claims named tools when
toolCountis 0; citation fixture isauJzb1D-fag.Verify after A (live pack)
GET https://uvai.io/api/video/pack?url=https://www.youtube.com/watch?v=pBsT6v-ciO8→ 200: noeventsfield, no packinsights, architecture present, artifacts 2, tools SeaDance/Claude Fable/Character.ai/Cluely, transcript 1767, keyframes 11 / concepts 8 / code_snippets 3. UI Events stay empty; those extras are not mapped into Events. Summary only appears if the workflow later writesselected.insights.Scope
OneLoopStudio,studio-pipeline-status, focused tests, plan noteOneLoopStudio.tsx)Risk
Verification
Head SHA:
b2611e9abstudio-handoff,studio-pipeline-status,action-surface,uvai-surface-unification,official-templates,home-sell-surface)9ba44c4bb(fix(web): do not hold anonymous Deploy on skip/unknown stack checks #1695) — no longer dirty vs mainevents[]/ no pack insightsAgent handoff