Repository navigation
Conversation
#2549 rewrote the landing hero and left home-sell-surface asserting the previous sentence. Co-authored-by: KK <kk-agent@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
github-actions
Bot
added
javascript
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Please add a See governance: #898 |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
This was referenced Nov 4, 2026
Owner
|
Closing as superseded. The same two assertion updates landed on main in #2546 (squash 6975815), where they were the only thing keeping that PR's |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
test-frontendon main (cd7e1998f, Actions run 41659258955) failed two assertions inapps/web/src/lib/__tests__/home-sell-surface.test.ts. Both expected the old hero sentenceprepares proposed work and build rails for you to review in Studio.git log -Son that string points atb05aae6f6(Align landing hero promise with Studio review capability, #2549). That commit intentionally rewrote the hero to:Studio prepares proposed work and build rails for you to review.The same commit updated
landing-style-safety.test.tsto the new sentence and did not touchhome-sell-surface.test.ts. The page copy is current. The test was stale.This PR updates those two assertions to the current sentence. No page copy and no other files change.
Scope
toContainassertions inhome-sell-surface.test.ts(lines 25 and 39).Risk
Verification
Local, on
bba5f1d78:npm --workspace=apps/web testResult: 176 files passed, 1535 tests passed, 28 skipped (1563). The skips are the Redis-gated suite; that local run did not set
ORIGIN_GATE_REDIS_TESTS=1.PR
test-frontendpassed on the same head: CI run 41672446320, job 126044083739. TheUnit tests (apps/web)step succeeded. That job installs Redis and setsORIGIN_GATE_REDIS_TESTS=1.Closing keyword check
Closing keyword to open issue(.github/workflows/require-issue-closer.yml) is expected to stay red. This audit fix has no open issue, and the task forbids creating one, so this body does not add a closing keyword. Leave that check alone. Do not merge.Production evidence
Not applicable. Test-only assertion update; no runtime or deployment change.