Repository navigation
chore(audit): delete unmounted dashboard skin - #2564
Merged
Merged
Conversation
Remove redirect-only pages and the canvas chain nothing mounts, and drop the store methods only that skin called. Co-authored-by: KK <kk-agent@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
🔍 PR Validation |
github-actions
Bot
added
javascript
Contributor
|
Please add a See governance: #898 |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Restore home-sell-surface and video-generator accessibility tests so this PR stays on the dashboard deletion. Co-authored-by: KK <kk-agent@users.noreply.github.com>
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #2328
Deletes the redirect-only dashboard skin and the store methods only that skin called.
next.config.jsredirects for/dashboard,/app,/prototype,/features, and/playgroundstay. No API route was deleted.OneLoopStudio.tsx,next.config.js,store/dashboard-types.ts, and the inventory docs were not edited.Findings
app/dashboard/page.tsx,dashboard/agents/page.tsx,app/app/page.tsx,app/prototype/page.tsx,prototype/layout.tsx,app/features/page.tsx,app/playground/page.tsx.rgon current main showed no other module imports them.auth-config-source.test.tsanduvai-surface-unification.test.tsnow assert the redirects innext.config.js.DashboardSplitView→DashboardCanvasView→panels.tsx, plusAgentDashboard,EventList,FeedbackWidget,TranscriptViewer,VideoCanvasStage, andInteractiveTranscript.rgfound no page or studio import.timestamp.tsnow importsTranscriptSegmentfrom@/lib/transcript-search, where that type already lived, thenInteractiveTranscript.tsxwas deleted.use-dashboard-detail.tsand its test. OnlyDashboardCanvasViewimported the hook.action-agent-store.tsand its test. Onlypanels.tsximported the store.feedback.tsandfeedback.test.ts. AfterFeedbackWidgetwas removed,submitFeedbackhad no caller and posted to/api/v1/feedback, which does not exist.dispatchToAgents,refreshAgentStatus,performSearch,extractEvents,resumeProcessingRuns, and the unreadactivities/addActivitylog plus its persistence fromdashboard-store.ts. Their tests were deleted. Persistence tests now expect videos only.library-contrast.test.ts,dashboard-search-accessibility.test.ts).studio-pipeline-status.test.tsno longer readspanels.tsx.searchQuery/searchResults/setSearchQueryremain becauseselectVideostill resets them.dashboard-analysis.tsremains because its own unit tests still import it./api/dashboard,/api/agents/*, and/api/video/search.Follow-up:
home-sell-surface.test.tsis restored. #2568 owns that assertion.video-generator-accessibility.test.tsis restored because #2559 deletes that file.Verification
npm ci --legacy-peer-depssucceeded.cd apps/web && npm run lintpassed.cd apps/web && npm run type-checkpassed.npm run build:webpassed (Next.js 16.4.3). The build route list has no/dashboard,/app,/prototype,/features, or/playgroundpages.home-sell-surface.test.tsis unchanged from main.No Python files changed, so local pytest was not run.
Closes #2582