Skip to content

chore(audit): trim stale narration and dead tooling in apps/web - #2589

Merged
groupthinking merged 1 commit into
mainfrom
cursor/trim-stale-narration-apps-web-3c81
Nov 4, 2026
Merged

groupthinking merged 1 commit into
mainfrom
cursor/trim-stale-narration-apps-web-3c81

Conversation

@kk-agent

@kk-agent kk-agent commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Canonical issue

Closes #2591

Outcome

Stale narration and dead tooling in apps/web are gone. The API reference matches the live handlers, and the homepage smoke spec expects the current heading.

Findings

  • Done: apps/web/src/app/api/transcribe/route.ts — trimmed the strategy-order and error-string essays to the status-code contract. rg on current main still showed that essay above POST.
  • Done: apps/web/src/app/docs/api/page.tsx — GET /api/video is a health probe (GET in api/video/route.ts checks /api/v1/health or returns API status). GET /api/dashboard maps backend health to status and metrics. POST /api/dashboard requests a backend embed URL, not pin/archive. No docs rows named UI deleted in chore(audit): delete unmounted dashboard skin #2564 / chore(audit): delete orphaned apps/web components and hooks #2559; those routes are still live, so the rows were corrected rather than removed.
  • Done: apps/web/playwright/smoke.spec.ts — heading expectation is now Your videos know what to do next. (page.tsx on main, same string as landing-page.spec.ts).
  • Done: deleted apps/web/types/styled-jsx.d.ts. Both declaration files match tsconfig.json **/*.ts. Kept apps/web/styled-jsx.d.ts (the fix(web): timerRef null type + styled-jsx React 19 type augmentation #435 augmentation). The types/ copy redeclared the same props plus media.
  • Done: deleted apps/web/.github/workflows/deploy.yml. GitHub only runs repo-root .github/workflows/. git ls-files showed this nested workflow and no sibling files under apps/web/.github.
  • Done: apps/web/scripts/run-revenue-spine.mjs — removed the pnpm exec vitest step whose cwd was ../../../../MyXstack/myxteam. The in-repo /api/billing/status record remains. REVENUE-PROCESS.md no longer says that step runs the external gate.
  • Done: apps/web/SITE_STRUCTURE_INVENTORY.md — removed route rows and component rows for the dashboard skin and files deleted in chore(audit): delete unmounted dashboard skin #2564 (C04) and chore(audit): delete orphaned apps/web components and hooks #2559 (C05). StructuredData and AuthSessionProvider stay in the layout notes; they were not deleted.
  • Skipped: apps/web/STUDIO_FUNCTIONAL_INVENTORY.md — rg found no rows naming the deleted skin or C04/C05 components. Remaining useDashboardStore lines describe the live store.

Related: #2328

Scope

  • Included: the files above.
  • Explicitly excluded: vitest.config.ts, api/video/route.ts, workflows/studio-deploy.ts, chat/route.ts, pricing/page.tsx, api/route.ts. No BACKEND_URL, SDK, or proxy wiring was removed.

Risk

  • Risk level: low
  • Failure mode: a caller still depended on the deleted types/styled-jsx.d.ts augmentation. rg found no importer; apps/web/styled-jsx.d.ts remains and is included by **/*.ts.
  • Rollback: revert this commit.

Verification

Head cd09bee36.

  • npm ci --legacy-peer-deps — passed (1024 packages)
  • npm run lint --workspace=apps/web — passed
  • npm --workspace=apps/web test — 167 files, 1493 passed, 28 skipped
  • npm run build:web — passed (Next.js 16.4.3, TypeScript finished)
  • No Python changes, so pytest was not run.

Production evidence

Not applicable. This changes comments, docs, a smoke expectation, and dead files. No production route behavior changed.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval
Open in Web Open in Cursor 

Closes #2591

Drop the transcribe comment essay, correct stale API docs, match the
smoke heading to the live home page, and delete the duplicate styled-jsx
augmentation, nested deploy workflow, and out-of-repo vitest step.

Co-authored-by: KK <kk-agent@users.noreply.github.com>
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Nov 4, 2026 10:19am UTC

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-04T10:18:10.711500Z
We couldn’t complete this review. Comment @codex review to try again.
cd09bee PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions github-actions Bot added ci/cd documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

⚠️ Repository reconciliation: this PR does not reference exactly one canonical issue.

Please add a Closes #<issue> reference in the PR description so it can be tracked against the delivery plan.

See governance: #898

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Test Results: ALL TESTS PASSED

Metric Value
Status 🟢 GREEN
Total Tests
Passed 16
Failed
Deployment https://v0-uvai-4chfdh604-garv1.vercel.app
Test Output
every request without persisting it�[32m 1�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mhomepage returns 200 with HTML�[32m 190�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mfeatures page contains template/workflow markup�[32m 210�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mTemplate Gallery�[2m > �[22mfeatures page surfaces at least 5 workflow/template indicators�[32m 165�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mVideo Pack Pipeline�[2m > �[22mPOST /api/video/pack accepts a YouTube URL without hanging�[33m 2055�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mVideo Pack Pipeline�[2m > �[22mGET /api/video/pack resolves to a ready pack with evidence lineage�[33m 626�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22mmissing URL returns 400, not a hang�[32m 131�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22minvalid URL returns 400 quickly, not a hang�[32m 103�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mError Handling�[2m > �[22mPOST /api/video/pack with no body returns 400�[32m 113�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mDashboard�[2m > �[22m/dashboard returns 200�[32m 200�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mDashboard�[2m > �[22m/dashboard contains agent or pipeline visualization markup�[32m 158�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mAPI Health�[2m > �[22mGET /api returns a response (not 404)�[32m 259�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mAPI Health�[2m > �[22mretired /api/pipeline routes are gone (no pipeline served)�[32m 73�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mStatic Assets�[2m > �[22mhomepage has proper meta tags�[32m 121�[2mms�[22m�[39m
 �[32m✓�[39m tests/e2e/pipeline.test.ts�[2m > �[22mEventRelay E2E — Live Deployment�[2m > �[22mStatic Assets�[2m > �[22m/features page returns 200�[32m 151�[2mms�[22m�[39m

�[2m Test Files �[22m �[1m�[32m1 passed�[39m�[22m�[90m (1)�[39m
�[2m      Tests �[22m �[1m�[32m16 passed�[39m�[22m�[90m (16)�[39m
�[2m   Start at �[22m 10:19:41
�[2m   Duration �[22m 6.22s�[2m (transform 32ms, setup 0ms, import 42ms, tests 6.11s, environment 0ms)�[22m


@groupthinking
groupthinking merged commit bd3e965 into main Nov 4, 2026
46 of 48 checks passed
@groupthinking
groupthinking deleted the cursor/trim-stale-narration-apps-web-3c81 branch November 4, 2026 15:03

This branch was successfully deployed

1 active deployment
Preview — cd09bee3 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd documentation Improvements or additions to documentation javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit cleanup: chore(audit): trim stale narration and dead tooling in apps/web

3 participants