Conversation
jamesgorrie
approved these changes
Feb 15, 2022
Contributor
jamesgorrie
left a comment
jamesgorrie
left a comment
There was a problem hiding this comment.
Given we don't use yarn install --production anywhere, as I can see, we weren't getting any benefit anywho.
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
Member
Author
if we should be doing that, we're not going to get all and only prod deps right now anyway. might as well make that explicit (and then fix it that's wrong) |
Member
|
Just adding to:
So if I can see that it is not set for the imo separating deps is worth it to:
|
tjmw
added a commit
that referenced
this pull request
Feb 22, 2022
This happened previously in #4001 but the change was subsequently lost. A couple of dependencies have been added in the meantime which is why there are a couple of straggling lines (@types/twitter-for-web for example).
mxdvl
added a commit
that referenced
this pull request
Feb 24, 2022
Since #4001 we collapsed dependencies. This helps us rely on our friendly robots to ensure we don’t start populating this field by mistake in package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
collapses each project's npm dependencies into the
dependenciesfieldWhy?
dependenciesanddevDependenciesof each package, it confuses usPrep work for #3998