Collapse all npm packages into dependencies#4050
Merged
Conversation
This happened previously in #4001 but the change was subsequently lost. A couple of dependencies have been added in the meantime which is why there are a couple of straggling lines (@types/twitter-for-web for example).
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
sndrs
approved these changes
Feb 22, 2022
Contributor
|
Could we add a little CI test for this? Something like import pkg from "./package.json";
if(pkg.devDependecies) throw new Error("no dev deps, please, see PR #4001"); |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This happened previously in #4001 but the change was subsequently lost. A couple of dependencies have been added in the meantime which is why there are a couple of straggling lines (
@types/twitter-for-webfor example).