feat: introduce forge-agnostic MergeMethod type in config#1
Open
harshs-dyte wants to merge 1 commit intomasterfrom
Open
feat: introduce forge-agnostic MergeMethod type in config#1harshs-dyte wants to merge 1 commit intomasterfrom
harshs-dyte wants to merge 1 commit intomasterfrom
Conversation
Replace the GitHub-specific genclient.PullRequestMergeMethod with a new config.MergeMethod string type and constants (MergeMethodMerge, MergeMethodSquash, MergeMethodRebase). This decouples the config package from the GitHub GraphQL client, allowing other forge implementations to use the same merge method configuration. - Rename Config.MergeMethod() to Config.ParseMergeMethod() - Add toGitHubMergeMethod() conversion in githubclient - Update mock client and tests to use config.MergeMethod commit-id:e1a2b3c4
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the GitHub-specific genclient.PullRequestMergeMethod with a new
config.MergeMethod string type and constants (MergeMethodMerge,
MergeMethodSquash, MergeMethodRebase). This decouples the config package
from the GitHub GraphQL client, allowing other forge implementations to
use the same merge method configuration.
Stack:
PullRequestURLaForgeInterfacemethod #13commit-idcheck in reword helper with main executable #10