refactor: migrate all packages from github types to forge types#4
Open
harshs-dyte wants to merge 1 commit intospr/master/f2b3c4d5from
Open
refactor: migrate all packages from github types to forge types#4harshs-dyte wants to merge 1 commit intospr/master/f2b3c4d5from
harshs-dyte wants to merge 1 commit intospr/master/f2b3c4d5from
Conversation
Replace all usages of github.GitHubInterface, github.GitHubInfo, github.PullRequest, github.RepoAssignee, and github.CheckStatus* with their forge package equivalents (forge.ForgeInterface, forge.ForgeInfo, forge.PullRequest, forge.RepoAssignee, forge.CheckStatus*). The github client now implements forge.ForgeInterface directly, the template package accepts forge types, and the spr command uses the forge abstraction layer. Main changes: - GitHub client: returns forge.PullRequest with URL field populated - GitHub client: uses shared forge.BuildPullRequestStack() - Mock client: implements forge.ForgeInterface - Templates: accept forge.ForgeInfo and forge.PullRequest - SPR core: depends on forge.ForgeInterface instead of github.GitHubInterface - PR String() uses pr.URL directly instead of building URL from config commit-id:a3b4c5d6
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all usages of github.GitHubInterface, github.GitHubInfo,
github.PullRequest, github.RepoAssignee, and github.CheckStatus*
with their forge package equivalents (forge.ForgeInterface,
forge.ForgeInfo, forge.PullRequest, forge.RepoAssignee, forge.CheckStatus*).
The github client now implements forge.ForgeInterface directly,
the template package accepts forge types, and the spr command uses
the forge abstraction layer.
Main changes:
Stack:
PullRequestURLaForgeInterfacemethod #13commit-idcheck in reword helper with main executable #10