Compact Metadata write part implementation. [API-1326] by OzanCansel · Pull Request #1039 · hazelcast/hazelcast-cpp-client

OzanCansel · 2022-12-08T10:00:48Z

Hazelcast server version change to 5.2.0 in rc-script.
Basic compact example added.
send_schema_request_encode and decode functions are added.
default_schema_service is added as member to hazelcast_client_instance_impl.h
ClientMessage::set is overloaded for serialization::pimpl::field_descriptor.
ClientMessage::set is overloaded for serialization::pimpl::schema.
field_kind is moved to field_kind.h.
compact.h is moved to compact/compact.h
compact.i.h is renamed to compact_impl.h and moved to compact/compact_impl.h.
default_schema_service is moved to default_schema_service.h.
field_descriptor is moved to compact/field_descriptor.h.
schema is moved to compact/schema.h.
will_be_replicated_schemas_ field is added to serialization::pimpl::data.
default_schema_service& parameter is added to constructor of SerializationService.
ClientInvocation is updated to replicate_schemas before actualy invocation.
enum field_kind changed to enum class field_kind.
Tests which uses SerializationService are refactored due to extra default_schema_service argument.
null_schema_service is added to TestHelperFunctions.h.
CompactSchemaReplicationOnWrite test is added.
CompactSchemaValidation test is added.
compact_test.cpp splitted into different files but they are not different translation unit. So it doesn't affect the compile time.
Serializable types related with compact moved to compact/serialization.
One fingerprint test is removed. (It is already included with other PR(will be merged), so the behaviour is covered).

devOpsHazelcast · 2022-12-08T10:01:57Z

Linux test FAILed.

devOpsHazelcast · 2022-12-08T10:03:02Z

Windows test FAILed.

devOpsHazelcast · 2022-12-08T11:10:24Z

Linux test FAILed.

devOpsHazelcast · 2022-12-08T11:10:55Z

Windows test FAILed.

devOpsHazelcast · 2022-12-08T11:44:46Z

Linux test FAILed.

devOpsHazelcast · 2022-12-08T11:45:49Z

Windows test FAILed.

devOpsHazelcast · 2022-12-08T12:05:35Z

Windows test FAILed.

devOpsHazelcast · 2022-12-08T12:10:28Z

Linux test FAILed.

devOpsHazelcast · 2022-12-08T12:15:48Z

Linux test FAILed.

devOpsHazelcast · 2022-12-08T12:16:35Z

Windows test FAILed.

devOpsHazelcast · 2022-12-08T13:44:29Z

Linux test FAILed.

devOpsHazelcast · 2022-12-08T13:45:55Z

Windows test FAILed.

devOpsHazelcast · 2022-12-08T14:59:41Z

Linux test FAILed.

devOpsHazelcast · 2022-12-08T15:00:47Z

Windows test FAILed.

devOpsHazelcast · 2022-12-08T15:01:18Z

Linux test FAILed.

devOpsHazelcast · 2022-12-08T15:04:31Z

Windows test FAILed.

devOpsHazelcast · 2022-12-09T06:16:50Z

Linux test FAILed.

devOpsHazelcast · 2022-12-09T06:24:58Z

Linux test FAILed.

devOpsHazelcast · 2022-12-09T06:28:39Z

Windows test FAILed.

devOpsHazelcast · 2022-12-09T06:29:08Z

Linux test FAILed.

devOpsHazelcast · 2022-12-09T06:32:24Z

Windows test FAILed.

devOpsHazelcast · 2022-12-09T06:36:18Z

Windows test FAILed.

devOpsHazelcast · 2022-12-09T06:45:08Z

Windows test FAILed.

devOpsHazelcast · 2022-12-09T06:45:36Z

Linux test FAILed.

devOpsHazelcast · 2022-12-09T06:59:14Z

Linux test FAILed.

…te_schema method is refactored.

…ad_pool

devOpsHazelcast · 2023-02-22T07:02:55Z

Linux test FAILed.

devOpsHazelcast · 2023-02-22T07:30:32Z

Linux test PASSed.

devOpsHazelcast · 2023-02-22T07:51:58Z

Linux test PASSed.

…t namespace.

devOpsHazelcast · 2023-02-22T08:36:45Z

Linux test FAILed.

devOpsHazelcast · 2023-02-22T09:01:46Z

Windows test FAILed.

devOpsHazelcast · 2023-02-22T09:02:02Z

Linux test PASSed.

devOpsHazelcast · 2023-02-22T10:12:05Z

Windows test FAILed.

devOpsHazelcast · 2023-02-22T10:35:36Z

Linux test PASSed.

ihsandemir

Looks good. Thanks for the effort.

devOpsHazelcast · 2023-02-22T14:14:46Z

Windows test FAILed.

devOpsHazelcast · 2023-02-22T14:24:17Z

Windows test FAILed.

devOpsHazelcast · 2023-02-22T14:39:22Z

Linux test FAILed.

devOpsHazelcast · 2023-02-22T14:39:34Z

Linux test FAILed.

devOpsHazelcast · 2023-02-22T15:11:06Z

Windows test PASSed.

devOpsHazelcast · 2023-02-22T15:33:19Z

Linux test PASSed.

akeles85

Nothing left to review

OzanCansel added this to the 5.2.0 milestone Dec 8, 2022

OzanCansel self-assigned this Dec 8, 2022

OzanCansel requested a review from ihsandemir December 8, 2022 10:25

OzanCansel force-pushed the compact-poc branch from ebcef13 to e284a1d Compare December 8, 2022 14:58

OzanCansel force-pushed the compact-poc branch from fdda065 to 9ae1ab4 Compare December 9, 2022 07:07

OzanCansel added 3 commits February 22, 2023 09:50

Return type changed to unordered_set. put_if_absent added and replica…

ddaa9bc

…te_schema method is refactored.

Unused variable removed.

19585c1

Replicate schema is made sync and executed on schema replication thre…

e7542c8

…ad_pool

OzanCansel force-pushed the compact-poc branch from af147eb to e7542c8 Compare February 22, 2023 06:55

compact_serializer, compact_reader, compact_writer is moved to compac…

1548abe

…t namespace.

OzanCansel force-pushed the compact-poc branch from aae48b4 to f9c9623 Compare February 22, 2023 09:46

ihsandemir previously approved these changes Feb 22, 2023

View reviewed changes

OzanCansel dismissed ihsandemir’s stale review via 214a369 February 22, 2023 14:05

OzanCansel force-pushed the compact-poc branch from f9c9623 to 214a369 Compare February 22, 2023 14:05

OzanCansel force-pushed the compact-poc branch from 214a369 to 0bc3fdc Compare February 22, 2023 14:20

Merge branch 'hazelcast:master' into compact-poc

00dd69d

OzanCansel force-pushed the compact-poc branch from 0bc3fdc to 00dd69d Compare February 22, 2023 14:34

ihsandemir approved these changes Feb 22, 2023

View reviewed changes

OzanCansel merged commit b3a962a into hazelcast:master Feb 22, 2023

akeles85 reviewed Mar 8, 2023

View reviewed changes

JackPGreen mentioned this pull request Oct 20, 2025

Update the ignore list of codecs for C++ and add missing type mappings [CTT-713] hazelcast/hazelcast-client-protocol#557

Merged

Conversation

OzanCansel commented Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 8, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Dec 9, 2022

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

ihsandemir left a comment

Choose a reason for hiding this comment

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

Uh oh!

devOpsHazelcast commented Feb 22, 2023

OzanCansel commented Dec 8, 2022 •

edited

Loading