Skip to content

Comments

Bump python-synology to 1.0.0#42161

Merged
Quentame merged 1 commit intohome-assistant:devfrom
hacf-fr:synology_dsm/bump
Oct 21, 2020
Merged

Bump python-synology to 1.0.0#42161
Quentame merged 1 commit intohome-assistant:devfrom
hacf-fr:synology_dsm/bump

Conversation

@Quentame
Copy link
Member

@Quentame Quentame commented Oct 21, 2020

Proposed change

Release notes : https://github.com/ProtoThis/python-synology/releases/tag/1.0.0

So fix "Requirement is pinned for python-synology 0.8.2: urllib3>=1.24.3,<1.25" ProtoThis/python-synology#63 from @MartinHjelmare

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@probot-home-assistant
Copy link

Hey there @hacf-fr, mind taking a look at this pull request as its been labeled with an integration (synology_dsm) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Quentame
Copy link
Member Author

Failed test not related

=========================== short test summary info ============================
FAILED tests/components/light/test_device_trigger.py::test_if_fires_on_state_change[pyloop]
Error: Process completed with exit code 1.

@Quentame Quentame merged commit bb641c2 into home-assistant:dev Oct 21, 2020
@Quentame Quentame deleted the synology_dsm/bump branch October 21, 2020 14:42
KJonline pushed a commit to Pyhass/core that referenced this pull request Oct 22, 2020
* 'dev' of github.com:home-assistant/core: (767 commits)
  [ci skip] Translation update
  Updated frontend to 20201021.1 (home-assistant#42185)
  Rewrite london_air tests in pytest style (home-assistant#41165)
  Enable co-existence of two IPMA weather entities for the same location (home-assistant#40354)
  Remove duplicated finalize_stream code in stream (home-assistant#42171)
  Bump simplisafe-python to 9.5.1 (home-assistant#42179)
  Remove coordinator success from SimpliSafe availability calculation (home-assistant#42180)
  Avoid overloading the executor with service.yaml loads (home-assistant#42172)
  Bump version to 0.118.0dev0 (home-assistant#42178)
  Add counter and timer to default_config (home-assistant#42174)
  Fix deCONZ device refresh service (home-assistant#42175)
  Update frontend to 20201021.0 (home-assistant#42173)
  Update base image to 2020.10.0 (home-assistant#42167)
  Add link to log view in persistent notification (home-assistant#42060)
  Bump Axis dependency (home-assistant#42168)
  Handle type error in hunterdouglas_powerview (home-assistant#42137)
  Add persistent_notification service to the notify platform (home-assistant#40638)
  Fix state overwrite race condition where two platforms request the same entity_id (home-assistant#42151)
  Bump python-synology to 1.0.0 (home-assistant#42161)
  Guard bad supported features for Google (home-assistant#42163)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SynologyDSMAPIErrorException if no cameras starting 0.116.0 Synology integration unable to add DSM

3 participants