Conversation
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with an integration ( |
elupus
left a comment
There was a problem hiding this comment.
Should we block this in the base platforms instead (entity, light...)?
But should really hurt to also handle it here.
|
The goal is to get it to annoy the user enough that it will report it to us :) |
|
Sure. But now we only annoy google assistant users :) |
|
Ps. We could annoy them much much better by making a google home announcement of the error ;) |
|
We should prevent to write bad states/entity to statemachine. However, a check like that is also not bad if we have this check |
|
I rather not add more checks to writing states. That will be a developer feature that would introduce runtime cost for normal usage. |
* 'dev' of github.com:home-assistant/core: (767 commits) [ci skip] Translation update Updated frontend to 20201021.1 (home-assistant#42185) Rewrite london_air tests in pytest style (home-assistant#41165) Enable co-existence of two IPMA weather entities for the same location (home-assistant#40354) Remove duplicated finalize_stream code in stream (home-assistant#42171) Bump simplisafe-python to 9.5.1 (home-assistant#42179) Remove coordinator success from SimpliSafe availability calculation (home-assistant#42180) Avoid overloading the executor with service.yaml loads (home-assistant#42172) Bump version to 0.118.0dev0 (home-assistant#42178) Add counter and timer to default_config (home-assistant#42174) Fix deCONZ device refresh service (home-assistant#42175) Update frontend to 20201021.0 (home-assistant#42173) Update base image to 2020.10.0 (home-assistant#42167) Add link to log view in persistent notification (home-assistant#42060) Bump Axis dependency (home-assistant#42168) Handle type error in hunterdouglas_powerview (home-assistant#42137) Add persistent_notification service to the notify platform (home-assistant#40638) Fix state overwrite race condition where two platforms request the same entity_id (home-assistant#42151) Bump python-synology to 1.0.0 (home-assistant#42161) Guard bad supported features for Google (home-assistant#42163) ...
Breaking change
Proposed change
Google Assistant could blow up if a bad integration inserted a string value for supported features into the state machine.
Fixes #40717
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: