Skip to content

femme is not just a dev dep anymore#511

Merged
yoshuawuyts merged 1 commit intohttp-rs:masterfrom
jbr:femme-not-a-dev-dep-anymore
May 17, 2020
Merged

femme is not just a dev dep anymore#511
yoshuawuyts merged 1 commit intohttp-rs:masterfrom
jbr:femme-not-a-dev-dep-anymore

Conversation

@jbr
Copy link
Copy Markdown
Member

@jbr jbr commented May 17, 2020

master is currently broken in the following way:

although cargo test and cargo build work just fine, a project created like

cargo new tide-example --bin
cd tide-example
cargo add tide --git=https://github.com/http-rs/tide.git
cargo build

results in this compile error

 error[E0277]: the trait bound `std::string::String: log::kv::value::ToValue` is not satisfied
   --> /Users/jbr/.cargo/git/checkouts/tide-ea61fd839c4268c0/f575a12/src/server.rs:302:21
    |
302 |                     log::error!("async-h1 error", { error: err.to_string() });
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `log::kv::value::ToValue` is not implemented for `std::string::String`
    |
    = note: required for the cast to the object type `dyn log::kv::value::ToValue`
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `tide`.

To learn more, run the command again with --verbose.

Adding this change to tide's dependencies fixes the issue. As of ee5f05e#diff-4ce93534efc34e923ce01e975eb7ed80R302 tide seems to need femme to compile.

@jbr jbr force-pushed the femme-not-a-dev-dep-anymore branch from 2a20a7c to 6dcbbb9 Compare May 17, 2020 05:06
@jbr jbr requested a review from yoshuawuyts May 17, 2020 05:08
Copy link
Copy Markdown
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh? I didn't realize it wasn't just a dev dep. Sure, let's merge this (:

@yoshuawuyts yoshuawuyts merged commit 2e24241 into http-rs:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants