Skip to content

add a no-dev-deps check to ci#512

Merged
yoshuawuyts merged 1 commit intohttp-rs:masterfrom
jbr:avoid-dev-deps-ci
May 18, 2020
Merged

add a no-dev-deps check to ci#512
yoshuawuyts merged 1 commit intohttp-rs:masterfrom
jbr:avoid-dev-deps-ci

Conversation

@jbr
Copy link
Copy Markdown
Member

@jbr jbr commented May 17, 2020

the build failure is the purpose of this pr, as master is broken until #511 is merged. this change will catch this sort of (rare) problem in the future

@jbr jbr force-pushed the avoid-dev-deps-ci branch 3 times, most recently from b106a54 to aff9fdc Compare May 17, 2020 04:50
@jbr jbr changed the title add a no-dev-deps check to ci add a no-dev-deps check to ci (ready for merge even though failing) May 17, 2020
@jbr jbr requested a review from yoshuawuyts May 17, 2020 05:08
@jbr jbr force-pushed the avoid-dev-deps-ci branch from aff9fdc to b2176d2 Compare May 17, 2020 18:24
@jbr jbr changed the title add a no-dev-deps check to ci (ready for merge even though failing) add a no-dev-deps check to ci May 17, 2020
Copy link
Copy Markdown
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is interesting; I like this a lot. Thanks!

@yoshuawuyts yoshuawuyts merged commit 89fd006 into http-rs:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants