Repository navigation
docs: consolidate mobile navigation and search in Drawer - #2287
Draft
maxffarrell wants to merge 24 commits into
Draft
maxffarrell wants to merge 24 commits into
maxffarrell wants to merge 24 commits into
Conversation
🦋 Changeset detectedLatest commit: 0b2ec74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
maxffarrell
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the mobile documentation menu and search into one Drawer below the
mdbreakpoint. Remove the separate hamburger menu. A single search trigger opens the drawer and focuses the search field; the keyboard shortcut also opens search. With an empty query, show the same grouped navigation as the sidebar, including Home, current-page indicators and navigation labels. Typing replaces navigation with documentation search results.Keep the sheet 8px below the site header and stationary when the keyboard opens or closes. Retain native results scrolling, swipe dismissal, an accessible close button, safe-area spacing, reduced motion, and compositor hints for open/close transitions. Desktop search continues to use a dialog.
Depends on #2285 and is based on its head at
d5567f42. This draft includes the Drawer commits until that PR lands. The documentation changes are isolated in the commits after that head.Validation:
pnpm lintsvelte-check: 0 errors and 0 warnings.pnpx tsxwrapper failed on an esbuild build-script policy.