Skip to content

Truncate too long focused group names#7289

Merged
acelaya merged 1 commit intomainfrom
truncate-group-name
Sep 15, 2025
Merged

Truncate too long focused group names#7289
acelaya merged 1 commit intomainfrom
truncate-group-name

Conversation

@acelaya
Copy link
Copy Markdown
Contributor

@acelaya acelaya commented Sep 9, 2025

Part of hypothesis/product-backlog#1660
Depends on #7292

Since the horizontal space available in the sidebar is limited, this PR ensures the name of the focused group is truncated with an ellipsis if it cannot fit the space left by the toolbar.

The entire group name can still be seen when hovering over it.

With a long group name, this is how it was seen before these changes:
image

And after:
image

Considerations

This is just part of a solution to multiple problems. The next pieces of work are described in hypothesis/product-backlog#1660 (comment), and will come after.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.47%. Comparing base (e1ee0df) to head (1aa7e18).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7289   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files         271      271           
  Lines       10947    10948    +1     
  Branches     2618     2618           
=======================================
+ Hits        10889    10890    +1     
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acelaya acelaya force-pushed the truncate-group-name branch from b6c8724 to 0fdafb3 Compare September 15, 2025 08:23
@acelaya acelaya changed the base branch from main to simplify-menu September 15, 2025 08:23
@acelaya acelaya force-pushed the truncate-group-name branch 2 times, most recently from 6891cda to f959532 Compare September 15, 2025 10:17
@acelaya acelaya marked this pull request as ready for review September 15, 2025 10:20
@acelaya acelaya mentioned this pull request Sep 15, 2025
3 tasks
Base automatically changed from simplify-menu to main September 15, 2025 10:23
@acelaya acelaya force-pushed the truncate-group-name branch from f959532 to 90e6d41 Compare September 15, 2025 10:24
@acelaya acelaya force-pushed the truncate-group-name branch from 90e6d41 to 1aa7e18 Compare September 15, 2025 12:12
@acelaya acelaya merged commit 96067d2 into main Sep 15, 2025
4 checks passed
@acelaya acelaya deleted the truncate-group-name branch September 15, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants