Skip to content

Use Popover for Menu dropdowns#7290

Closed
acelaya wants to merge 1 commit intomainfrom
menu-popover
Closed

Use Popover for Menu dropdowns#7290
acelaya wants to merge 1 commit intomainfrom
menu-popover

Conversation

@acelaya
Copy link
Copy Markdown
Contributor

@acelaya acelaya commented Sep 10, 2025

Refactor Menu component so that it displays the dropdown inside a Popover component.

TODO

  • Close popover when a menu item is clicked
  • Close popover when clicking a submenu item, not its surrounding submenu.
  • Make sure dropdown works when popover API is not supported (asNativePopover={false})

@acelaya acelaya force-pushed the menu-popover branch 3 times, most recently from 2c82393 to abebcde Compare September 11, 2025 09:08
@acelaya
Copy link
Copy Markdown
Contributor Author

acelaya commented Sep 15, 2025

This PR was a pre-requisite to simplify the DOM structure in the groups Menu, and allow long group names to be truncated.

However, that has been achieved reasonably via #7292 and #7289, so I'm closing this for now, as it presents new challenges.

We still probably want to migrate to Popover eventually, ideally when all browsers we support can use the native Popover API.

@acelaya acelaya closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant