Skip to content

Comments

Fix too wide text in quick hero info box#8175

Merged
ihhub merged 1 commit intoihhub:masterfrom
a1exsh:fix-too-wide-quick-info-text
Dec 25, 2023
Merged

Fix too wide text in quick hero info box#8175
ihhub merged 1 commit intoihhub:masterfrom
a1exsh:fix-too-wide-quick-info-text

Conversation

@a1exsh
Copy link
Contributor

@a1exsh a1exsh commented Dec 24, 2023

Mostly for too wide translations.

  • Before:
    image

  • After:
    image

Related: #8173

@a1exsh
Fix too wide text in quick hero info box
3d70c2b 
Mostly for too wide translations.
@Districh-ru Districh-ru added improvement New feature, request or improvement ui UI/GUI related stuff labels Dec 24, 2023
@Districh-ru Districh-ru added this to the 1.1.0 milestone Dec 24, 2023
@ihhub ihhub requested a review from Districh-ru December 25, 2023 03:08
@ihhub ihhub merged commit 002ff8e into ihhub:master Dec 25, 2023
@ihhub
Copy link
Owner

ihhub commented Dec 25, 2023

@a1exsh , thank you so much for the fix!

Mr-Bajs added a commit to Mr-Bajs/fheroes2 that referenced this pull request Dec 26, 2023
@Mr-Bajs
Fix
e298da5 
Updated due to ihhub#8175
@Mr-Bajs
Copy link
Contributor

Mr-Bajs commented Dec 26, 2023

Mostly for too wide translations.

* Before:
  ![image](https://private-user-images.githubusercontent.com/489601/292681486-f4680692-528d-4809-a239-669c8db7f5e0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDM1OTY2NjAsIm5iZiI6MTcwMzU5NjM2MCwicGF0aCI6Ii80ODk2MDEvMjkyNjgxNDg2LWY0NjgwNjkyLTUyOGQtNDgwOS1hMjM5LTY2OWM4ZGI3ZjVlMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTIyNlQxMzEyNDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMWViYzA2OGZkM2IwOTMwZmUzNDM0NTkwMjk1YTVkYjdlOWM0ZTBjYWQyZTlmZDhiNjgwNjY1MDAzODE4ODFkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.lfgR-fLY9C5AXrr_Q5ZAD5z_H-6wEmjxK1h1-oLkrkY)

* After:
  ![image](https://private-user-images.githubusercontent.com/489601/292681489-0cffbf08-25f2-4c97-b045-9fe2de50caeb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDM1OTY2NjAsIm5iZiI6MTcwMzU5NjM2MCwicGF0aCI6Ii80ODk2MDEvMjkyNjgxNDg5LTBjZmZiZjA4LTI1ZjItNGM5Ny1iMDQ1LTlmZTJkZTUwY2FlYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMjI2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTIyNlQxMzEyNDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ZjNjYWE2ZTI1N2MyMmMyMDdlZjBkNGVmMjZjODIyYTA2YjZiZmRhZTJjNTcxMTI4ZDI0ZTY1YTgzNGNhYTY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Xg1-vJ7nDfV4eJYiVQMVmH7o3KX2n0Ht2BL1jewQMRw)

Related: #8173

Should the colon : be removed?
Shouldn't it end ...: in this case rather then just ...?

Kazhuu pushed a commit to Kazhuu/fheroes2 that referenced this pull request Jan 31, 2024
@a1exsh @Kazhuu
Fix too wide text in quick hero info box (ihhub#8175)
a7eda56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihhub ihhub ihhub approved these changes

@Districh-ru Districh-ru Districh-ru approved these changes

Assignees

@a1exsh a1exsh

Labels

improvement New feature, request or improvement ui UI/GUI related stuff

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@a1exsh @ihhub @Mr-Bajs @Districh-ru