converts subprocess outputs to text for user ids

[dberenbaum]

Avoids the error below (from testing locally) by returning text instead of bytes. This should be throwing errors for GH and BB CI jobs. Has anyone noticed the metrics looking odd?

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/dave/miniforge3/lib/python3.10/os.py", line 684, in __setitem__
    value = self.encodevalue(value)
  File "/Users/dave/miniforge3/lib/python3.10/os.py", line 756, in encode
    raise TypeError("str expected, not %s" % type(value).__name__)
TypeError: str expected, not bool

[casperdcl]

lgtm

[mike0sv]

ltgbm, but for checks to pass you probably need to change flake8 repo to https://github.com/pycqa/flake8 in pre-commit config

[codecov-commenter]

Codecov Report

Base: 50.63% // Head: 49.78% // Decreases project coverage by -0.85% ⚠️

Coverage data is based on head (e804c43) compared to base (1f7faee).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   50.63%   49.78%   -0.85%     
==========================================
  Files           2        2              
  Lines         237      237              
  Branches       36       22      -14     
==========================================
- Hits          120      118       -2     
- Misses        116      119       +3     
+ Partials        1        0       -1     

Impacted Files	Coverage Δ
src/iterative_telemetry/__init__.py	43.47% <ø> (ø)
tests/test_user_id.py	93.33% <0.00%> (-6.67%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dberenbaum]

Okay, now I'm really lost as to why the tests are failing 😕 😓. Here's the CI failure:

https://github.com/iterative/telemetry-python/actions/runs/3961526270/jobs/6787062038#step:5:70

The error there says:

src/iterative_telemetry/init.py:35:4: C0321: More than one statement on a single line (multiple-statements)

The offending line:

telemetry-python/src/iterative_telemetry/__init__.py

Line 35 in ab9e9ea

interface: str

[mike0sv]

Strange indeed. I have battled with weird pylint behavior in different python versions before and my suggestion is to just ignore it 😆 . Add this check to warnings list in pyproject.toml?

[mike0sv]

Also @skshetry bumped pylint version, maybe it will help?

[dberenbaum]

I'm fine to ignore but don't have permissions to merge, so I'll leave it up to you all at this point.

[mike0sv]

I meant add multiple-statements to disable section in pylint config in pyproject.toml so the checks would pass :)

[dberenbaum]

ping @mike0sv @casperdcl - could one of you merge please?