analytics: differentiate ci users #8838
Conversation
Codecov ReportBase: 93.39% // Head: 93.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8838 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 453 453
Lines 36341 36345 +4
Branches 5267 5268 +1
=======================================
+ Hits 33939 33946 +7
+ Misses 1887 1885 -2
+ Partials 515 514 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@dberenbaum, are you waiting for release? See https://github.com/iterative/dvc/wiki/Release-checklist#release-checklist. Otherwise let me know, I can cut a release as well. |
|
I guess I'm waiting for a release of https://github.com/iterative/telemetry-python before I can merge this. |
Right, that's what I meant. That checklist can be used to release any py-template based projects. Do you want to make a release yourself? |
|
@skshetry Opened https://github.com/iterative/telemetry-python/releases. Would you mind reviewing and publishing? Thanks! |
|
Done. It’ll take a few minutes to get to pypi. Btw, do you have permissions to make a release there? No need to make a draft tbh. |
Yeah, but I thought it couldn't hurt this time to be a little cautious. |
dberenbaum
force-pushed
the
ci-telemetry
branch
from
4af6169 to
2a755eb
Compare
|
Should be ready to merge now |
| from dvc import __version__ | ||
| from dvc.utils import is_binary | ||
|
|
||
| ci_id = _generate_ci_id() |
There was a problem hiding this comment.
A private function may break in the future.
|
@skshetry Would you mind merging? |
2 participants
This would help to separate CI users in analytics. Depends on iterative/telemetry-python#53.
Also needs a docs update in https://dvc.org/doc/user-guide/analytics.