Skipping testEighTinyNorm due to hipSolver issues

[AratiGanesh]

Motivation

The testEighTinyNorm test fails on ROCm devices due to numerical precision issues in the underlying hipSolver

Technical Details

Added @jtu.skip_on_devices("rocm") decorator to skip testEighTinyNorm in `tests/linalg_test.py

Test Result

Submission Checklist
Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

[gemini-code-assist]

Summary of Changes

Hello @AratiGanesh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a temporary workaround for a known numerical precision issue affecting ROCm devices. By conditionally skipping the testEighTinyNorm test on these platforms, it prevents test failures and maintains the stability of the test suite, while clearly documenting the root cause and the intention to re-enable the test in the future.

Highlights

• Test Skipping for ROCm: The testEighTinyNorm test is now conditionally skipped on ROCm devices to prevent failures caused by numerical precision issues in the hipSolver library.
• Issue Acknowledgment: A comment has been added to the skipped test, noting the specific hipSolver issue (ROCm 7.2) and a TODO to re-enable the test once the underlying problem is resolved.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tests/linalg_test.py
  • Introduced a conditional block using jtu.is_device_rocm() to detect ROCm environments.
  • Added self.skipTest() within this block for testEighTinyNorm, along with a descriptive message.
  • Included comments explaining the reason for the skip (hipSolver numerical errors as of ROCm 7.2) and a TODO for future re-enablement.

Activity

• The author has identified a test failure on ROCm devices due to a hipSolver issue (SWDEV-578349).
• The author has provided a screenshot of test results, likely demonstrating the fix or the original failure.
• The author has reviewed the contributing guidelines as per the submission checklist.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request skips testEighTinyNorm on ROCm devices to work around a hipSolver issue. The implementation uses a conditional self.skipTest inside the test method. My feedback suggests using the idiomatic @jtu.skip_on_devices("rocm") decorator instead for better code clarity and consistency. This also fixes a minor typo in the test name within the skip message.