Add input validation to team_fielding_bref#502
Open
yasumorishima wants to merge 1 commit intojldbc:masterfrom
Open
Add input validation to team_fielding_bref#502yasumorishima wants to merge 1 commit intojldbc:masterfrom
yasumorishima wants to merge 1 commit intojldbc:masterfrom
Conversation
- Add team.upper() to handle case-insensitive team abbreviations - Add end_season < start_season validation with clear error message Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
team.upper()to handle case-insensitive team abbreviations (e.g.,"oak"→"OAK")end_season < start_seasonvalidation with a clear error messageCloses #462
Details
Previously, passing a lowercase team abbreviation like
"oak"caused anAttributeErrorbecause the URL constructed with the lowercase string returned no matching HTML elements. Adding.upper()follows the same pattern used inteam_results.py.Additionally, passing
end_seasonbeforestart_season(e.g.,team_fielding_bref("NYY", 2023, 2020)) silently returned an empty DataFrame. Now it raises aValueErrorwith a clear message.