Skip to content

Add input validation to team_fielding_bref #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasumorishima wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add input validation to team_fielding_bref #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pybaseball/team_fielding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ def team_fielding_bref(team: str, start_season: int, end_season: Optional[int]=N
)
if end_season is None:
end_season = start_season
if end_season < start_season:
raise ValueError(
"end_season must be greater than or equal to start_season."
)

team = team.upper()
url = "https://www.baseball-reference.com/teams/{}".format(team)

raw_data = []
Expand Down