Skip to content

test: unit tests for the cli#459

Merged
antialias merged 2 commits intojsonresume:masterfrom
antialias:cli-tests
Dec 15, 2020
Merged

test: unit tests for the cli#459
antialias merged 2 commits intojsonresume:masterfrom
antialias:cli-tests

Conversation

@antialias
Copy link
Contributor

@antialias antialias commented Dec 11, 2020

No description provided.

@antialias antialias changed the title unit tests for the cli test: unit tests for the cli Dec 11, 2020
@antialias antialias mentioned this pull request Dec 11, 2020
Closed
rbardini
rbardini reviewed Dec 13, 2020
View reviewed changes
@antialias antialias requested a review from rbardini December 13, 2020 13:45
@antialias antialias mentioned this pull request Dec 13, 2020
Merged
thomasdavis
thomasdavis approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@thomasdavis thomasdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbardini
Copy link
Contributor

rbardini commented Dec 15, 2020

Test step is failing on master since 245ea94 (probably introduced by 6c9b0d1, but it failed earlier). Does this PR fix the issue?

Only our PR workflow is running on pull requests from forks, that's probably why we didn't catch it before merging.

@antialias
Copy link
Contributor Author

antialias commented Dec 15, 2020

Test step is failing on master since 245ea94 (probably introduced by 6c9b0d1, but it failed earlier). Does this PR fix the issue?

Only our PR workflow is running on pull requests from forks, that's probably why we didn't catch it before merging.

PR that fixes regression #463

@antialias antialias merged commit 80ba873 into jsonresume:master Dec 15, 2020
@antialias antialias deleted the cli-tests branch December 15, 2020 17:16
antialias pushed a commit to antialias/resume-cli that referenced this pull request Dec 16, 2020
squash! test: unit tests for the cli (jsonresume#459)
2d457fa 
fixing theme resolution on node after v10
antialias pushed a commit to antialias/resume-cli that referenced this pull request Dec 16, 2020
squash! test: unit tests for the cli (jsonresume#459)
8606841 
fixing theme resolution on node after v10
antialias pushed a commit to antialias/resume-cli that referenced this pull request Dec 17, 2020
squash! test: unit tests for the cli (jsonresume#459)
681b0df 
fixing theme resolution on node after v10
antialias pushed a commit to antialias/resume-cli that referenced this pull request Dec 17, 2020
squash! test: unit tests for the cli (jsonresume#459)
e7f11e5 
fixing theme resolution on node after v10
antialias added a commit that referenced this pull request Dec 17, 2020
@antialias
squash! test: unit tests for the cli (#459) (#469)
85e76be 
fixing theme resolution on node after v10
@github-actions
Copy link

github-actions bot commented Dec 17, 2020

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

antialias pushed a commit to antialias/resume-cli that referenced this pull request Jan 15, 2021
fixup! squash! test: unit tests for the cli (jsonresume#459) (jsonres…
ebc938c 
…ume#469)
antialias pushed a commit to antialias/resume-cli that referenced this pull request Jan 15, 2021
fixup! squash! test: unit tests for the cli (jsonresume#459) (jsonres…
e31a7f6 
…ume#469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasdavis thomasdavis thomasdavis approved these changes

@rbardini rbardini Awaiting requested review from rbardini

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antialias @rbardini @thomasdavis