Conversation
8367f4b to
88d9070
Compare
|
Would like to see the split out of containerd as a separate binary in its own PR (that gets merged before this kind of bump). |
5da55dd to
ac02c3d
Compare
ac02c3d to
29ace38
Compare
|
I understand that separate binary is needed because opentelemetry but is containerd 1.6.0 release really so far that K3s 1.23 versions cannot wait that? I was hoping that we would be able to solve #4545 on 1.23 and I assume that other RKE2 users would like to see it too. |
|
containerd v1.6.0 isn't out yet; I have no idea what their target date is for releasing that. Even if it did come out today, we would probably be somewhat reluctant to ship a .0 release. |
ea91295 to
644eb2a
Compare
There was a problem hiding this comment.
- The k3s-root bump should be in a separate PR. I want to see it as a standalone change in the git log as well as tested end-to-end on its own.
- The containerd split should be in a separate PR that includes an ADR. As with k3s-root, I want to see it as a standalone change in the git log as well as tested end-to-end on its own.
Sorry, I thought based on our conversation in standup the other day that we were OK not doing these separately since no-one else cared to see them split out. I can take a moment to create additional PRs for those, but since they are required to successfully build 1.23, I will also leave those commits here and then rebase on top of the merged versions once they're in. |
e42b46c to
dfc606c
Compare
Oats87
left a comment
There was a problem hiding this comment.
LGTM; should we torch the vendor directory ....?
| "github.com/google/cadvisor/machine" | ||
| "github.com/google/cadvisor/utils/sysfs" | ||
| "github.com/sirupsen/logrus" | ||
| "k8s.io/component-helpers/node/util/sysctl" |
| # Ignore vendor folder and check file names as well | ||
| # Note: ignore "ba" in https://github.com/k3s-io/k3s/blob/4317a91/scripts/provision/vagrant#L54 | ||
| codespell --skip=.git,./vendor,MAINTAINERS --check-filenames --ignore-words-list=ba | ||
| codespell --skip=.git,./vendor,MAINTAINERS,go.mod,go.sum --check-filenames --ignore-words-list=ba |
There was a problem hiding this comment.
We should definitely make sure to get this into our other branches
dweomer
left a comment
There was a problem hiding this comment.
LGTM (assuming the cri-tools mismatch is on purpose and will be dealt with via follow-on PR)
0eaa6f3 to
4a63c94
Compare
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
4a63c94 to
123a723
Compare
Proposed Changes
Move containerd out to a separate binaryMoved to Standalone containerd #4757
Fix CI issuesMoved out to Fix multiple CI issues blocking 1.23 release #4801
Types of Changes
Upstream version change
Verification
kubectl --versionLinked Issues
User-Facing Change
Further Comments