Fix multiple CI issues blocking 1.23 release#4801
Merged
brandond merged 4 commits intok3s-io:masterfrom Dec 21, 2021
Merged
Conversation
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This failed if the build metadata contained a period, as in v1.23.0-rc.0 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Closes a gap in test coverage. Also fixes an issue where args and hooks from previous test runs were not being reset for subsequent runs. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
changed the title
galal-hussein
approved these changes
Dec 21, 2021
briandowns
approved these changes
Dec 21, 2021
Oats87
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Breaking out multiple CI fixes that were necessary for 1.23:
Types of Changes
ci bugfix
Verification
Linked Issues
User-Facing Change
Further Comments