Skip to content

Fix constant access in Jp2kDecoderAsync.kt#85

Merged
keiji merged 1 commit intomainfrom
fix-constant-access-2833856588561234874
Jan 21, 2026
Merged

Fix constant access in Jp2kDecoderAsync.kt#85
keiji merged 1 commit intomainfrom
fix-constant-access-2833856588561234874

Conversation

@google-labs-jules
Copy link
Contributor

Removed redundant local constant aliases in Jp2kDecoderAsync and updated usage to reference top-level constants from Constants.kt directly, adhering to Kotlin coding conventions and addressing a TODO comment.


PR created automatically by Jules for task 2833856588561234874 started by @keiji

Refactored `Jp2kDecoderAsync.kt` to remove redundant local constants `SCRIPT_BYTES_BASE64_CONVERTER_LOCAL`, `SCRIPT_IMPORT_OBJECT_LOCAL`, and `SCRIPT_DEFINE_DECODE_J2K`. Updated `loadWasm` to access the top-level constants `SCRIPT_BYTES_BASE64_CONVERTER`, `SCRIPT_IMPORT_OBJECT`, and `SCRIPT_DEFINE_DECODE_J2K` from `Constants.kt` directly. This change also resolves a pending "Fix" comment regarding incorrect class-based access to top-level properties.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@keiji keiji marked this pull request as ready for review January 21, 2026 10:49
@keiji keiji merged commit 7651709 into main Jan 21, 2026
2 checks passed
@keiji keiji deleted the fix-constant-access-2833856588561234874 branch January 21, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments