Skip to content

Fix constant access in Jp2kDecoderAsync.kt #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keiji merged 1 commit into from
Jan 21, 2026
Merged

Fix constant access in Jp2kDecoderAsync.kt #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions android/lib/src/main/java/dev/keiji/jp2k/Jp2kDecoderAsync.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ class Jp2kDecoderAsync(
val wasmBase64String = Base64.getEncoder().encodeToString(wasmBytes)

val script = """
$SCRIPT_BYTES_BASE64_CONVERTER_LOCAL
$SCRIPT_BYTES_BASE64_CONVERTER

var wasmInstance;
const wasmBuffer = globalThis.base64ToBytes('$wasmBase64String');

$SCRIPT_IMPORT_OBJECT_LOCAL
$SCRIPT_IMPORT_OBJECT

WebAssembly.instantiate(wasmBuffer, importObject).then(res => {
wasmInstance = res.instance;
Expand Down Expand Up @@ -418,11 +418,5 @@ class Jp2kDecoderAsync(
private const val TAG = "Jp2kDecoderAsync"
private const val MIN_INPUT_SIZE = 12 // Signature box length
private const val ASSET_PATH_WASM = "openjpeg_core.wasm"

private const val SCRIPT_BYTES_BASE64_CONVERTER_LOCAL = SCRIPT_BYTES_BASE64_CONVERTER
// Script to import WASI polyfill
// Fix: Use top-level constant from Constants.kt directly. Accessing via Class name 'Constants' is incorrect for top-level properties.
private const val SCRIPT_IMPORT_OBJECT_LOCAL = SCRIPT_IMPORT_OBJECT
private val SCRIPT_DEFINE_DECODE_J2K = dev.keiji.jp2k.SCRIPT_DEFINE_DECODE_J2K
}
}