chore(timezone): stackblitz examples (#DS-4896)#1512
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
Visit the preview URL for this PR (updated for commit 4af21eb): https://koobiq-next--prs-1512-2cntrvo7.web.app (expires Sat, 02 May 2026 08:47:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
There was a problem hiding this comment.
Pull request overview
Updates the timezone docs examples to be StackBlitz-friendly by removing the shared mock fixture and embedding a smaller timezone dataset directly in the example sources, plus adjusting the dev showcase module accordingly.
Changes:
- Inline a reduced
timezonesdataset into the timezone docs examples (and remove the large sharedmock.tsfixture). - Update timezone component e2e fixture data to no longer import from docs-examples.
- Switch the components-dev timezone showcase to import the standalone example components directly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/docs-examples/components/timezone/timezone-trigger-overview/timezone-trigger-overview-example.ts | Replaces ../mock import with inlined timezone data for the trigger example. |
| packages/docs-examples/components/timezone/timezone-search-overview/timezone-search-overview-example.ts | Replaces ../mock import with inlined timezone data for the searchable select example. |
| packages/docs-examples/components/timezone/timezone-overview/timezone-overview-example.ts | Replaces ../mock import with inlined timezone data for the basic select example. |
| packages/docs-examples/components/timezone/mock.ts | Removes the large shared timezone fixture file. |
| packages/components/timezone/e2e.ts | Replaces docs-examples fixture import with inlined e2e timezone data and updates usage. |
| packages/components-dev/timezone/module.ts | Imports individual timezone example components instead of TimezoneExamplesModule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
|
@artembelik почему изменения в примере для stackblitz зацепило скриншот тесты ? |
timezone массив (mock) изменился, вместо нескольких тысяч строк, оставил только ru |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
обновить скриншоты после мержа #1516 |
|
@copilot resolve the merge conflicts in this pull request |
Merge conflicts resolved in db85dce. The only conflicts were binary screenshot files — resolved by keeping our branch's versions (which reflect the reduced timezone dataset). All other upstream changes from |
artembelik
force-pushed
the
chore/DS-4896
branch
from
db85dce to
4ff87ab
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
#1516