fix(timezone): use select tokens (#DS-4901)#1516
Merged
Merged
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
Contributor
Author
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
Visit the preview URL for this PR (updated for commit 31f9b7c): https://koobiq-next--prs-1516-q6svoigq.web.app (expires Tue, 28 Apr 2026 10:04:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates timezone select styling to consume shared kbq-select token definitions instead of duplicating/overriding them locally.
Changes:
- Add
select-tokens.scsstoKbqTimezoneSelectstyles so the timezone panel inherits shared select CSS variables. - Remove duplicated select-related CSS variables from
timezone-option-tokens.scss. - Adjust shared
select-tokens.scsssingle-select padding variables.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/components/timezone/timezone-select.component.ts | Includes shared select token stylesheet alongside existing select styles for timezone select. |
| packages/components/timezone/timezone-option-tokens.scss | Drops duplicated select padding + panel theme tokens so timezone select relies on shared select tokens. |
| packages/components/select/select-tokens.scss | Changes shared single-select padding CSS variables to 0, affecting all selects using these tokens. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Snapshots updated! |
lskramarov
approved these changes
Apr 24, 2026
NikGurev
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.