MTV-4517 | standardise version embedding using git-describe#4595
MTV-4517 | standardise version embedding using git-describe#4595mnecas merged 1 commit intokubev2v:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4595 +/- ##
==========================================
- Coverage 15.45% 10.03% -5.42%
==========================================
Files 112 468 +356
Lines 23377 53463 +30086
==========================================
+ Hits 3613 5367 +1754
- Misses 19479 47629 +28150
- Partials 285 467 +182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rgolangh
force-pushed
the
standardise-version-extraction
branch
from
c991f73 to
50e4199
Compare
rgolangh
changed the title
rgolangh
force-pushed
the
standardise-version-extraction
branch
3 times, most recently
from
eb93ba7 to
5f5fc0c
Compare
rgolangh
force-pushed
the
standardise-version-extraction
branch
2 times, most recently
from
9341b40 to
08af95f
Compare
rgolangh
force-pushed
the
standardise-version-extraction
branch
from
08af95f to
11da0ec
Compare
rgolangh
force-pushed
the
standardise-version-extraction
branch
from
11da0ec to
ef2c5ed
Compare
| @@ -1,5 +1,4 @@ | |||
| # Ignore Git files | |||
| .git | |||
There was a problem hiding this comment.
Had to remove this so the git info be used inside the container build
rgolangh
force-pushed
the
standardise-version-extraction
branch
from
1b19daa to
14530f8
Compare
Resolves: MTV-4166
By using git describe the version of the binary becomes dependant on git
as source-of-truth. When combined with tags this is how the version
string looks like when the HEAD has the tag 'v2.10.4'
I0208 19:25:09.323603 3637005 vsphere-xcopy-volume-populator.go:313] binary=vsphere-xcopy-volume-populator version=v2.10.4 vib_version=0.3.0 vmkfstools_wrapper_version=0.3.0
If the HEAD is 2 commits above the tag v2.10.4 then version will be:
v2.10.4-2-g{GIT_COMMIT_SHA}
Signed-off-by: Roy Golan <rgolan@redhat.com>
rgolangh
force-pushed
the
standardise-version-extraction
branch
from
14530f8 to
33abad4
Compare
|
rgolangh
changed the title
|
commit message should say MTV-4517. Will fix on downport |
|
/backport release-2.11 |
|
🔄 Backport Status Starting backport of PR #4595 to |
|
✅ Backport Completed Successfully PR #4595 has been successfully backported to A new pull request should have been created with the backported changes. |
4 participants
Resoles: MTV-4517
By using git describe the version of the binary becomes dependant on git
as source-of-truth. When combined with tags this is how the version
string looks like when the HEAD has the tag 'v2.10.4'
If the HEAD is 2 commits above the tag v2.10.4 then version will be:
v2.10.4-2-g{GIT_COMMIT_SHA}
Signed-off-by: Roy Golan rgolan@redhat.com