[release-2.11] MTV-4517 | standardise version embedding using git-describe#4828
Open
github-actions[bot] wants to merge 1 commit intorelease-2.11from
Open
[release-2.11] MTV-4517 | standardise version embedding using git-describe#4828github-actions[bot] wants to merge 1 commit intorelease-2.11from
github-actions[bot] wants to merge 1 commit intorelease-2.11from
Conversation
github-actions
bot
requested review from
Hazanel,
mnecas,
mrnold,
rgolangh,
solenoci and
yaacov
as code owners
Resolves: MTV-4517
By using git describe the version of the binary becomes dependant on git
as source-of-truth. When combined with tags this is how the version
string looks like when the HEAD has the tag 'v2.10.4'
I0208 19:25:09.323603 3637005 vsphere-xcopy-volume-populator.go:313] binary=vsphere-xcopy-volume-populator version=v2.10.4 vib_version=0.3.0 vmkfstools_wrapper_version=0.3.0
If the HEAD is 2 commits above the tag v2.10.4 then version will be:
v2.10.4-2-g{GIT_COMMIT_SHA}
Signed-off-by: Roy Golan <rgolan@redhat.com>
rgolangh
force-pushed
the
bp-release-2.11-33abad4
branch
from
f3d7025 to
8dd7254
Compare
Collaborator
|
solenoci
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #4595
Resoles: MTV-4517
By using git describe the version of the binary becomes dependant on git
as source-of-truth. When combined with tags this is how the version
string looks like when the HEAD has the tag 'v2.10.4'
If the HEAD is 2 commits above the tag v2.10.4 then version will be:
v2.10.4-2-g{GIT_COMMIT_SHA}
Signed-off-by: Roy Golan rgolan@redhat.com