Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Owner O13: “can we setup ai search & fuzzy search and just overall better search algorithm for t3code android. also move the search bar to the bottom and lets think thru how to improve navigation while not adding too much clutter at the bottom since nav bar is there too. generate a few prototypes and fix the search algo first in parallel”
Mobile active, pending, sidebar, and archived search previously used inconsistent matching. This Draft PR addresses the algorithm first, not AI/semantic retrieval or bottom navigation. Qualification found a ranking defect: searching
archpreferred a one-edit typo (Arxh) over the exact contiguous substring inSearch.Design
Change (file:line at head
35dc2bbe6fa1b108d96dbfcb249913cc7856274d)apps/mobile/src/features/threads/mobileThreadSearch.ts:68-80: rank exact contiguous substrings ahead of one-edit typos; retain prefix and short-token gates.apps/mobile/src/features/threads/mobileThreadSearch.test.ts:20-91: table-driven typo, relevance-tier, quality, and recency/stable-tie regressions.apps/mobile/src/features/threads/threadListV2.ts:675: active thread and message search use the matcher.apps/mobile/src/features/archive/archivedThreadList.ts: archived search shares the matcher.apps/mobile/src/features/threads/useThreadListV2.ts: pending tasks use shared matching.apps/mobile/src/features/home/HomeScreen.tsx:468andapps/mobile/src/features/threads/ThreadNavigationSidebar.tsx:310: provide displayed project names to matching.Tests
UNRUN locally: connector cannot execute Vite Plus, TypeScript, or an Android build. New table-driven cases are present but not claimed passing.
vp test run apps/mobile/src/features/threads/mobileThreadSearch.test.ts— unrun.vp test run apps/mobile/src/features/threads/threadListV2.test.ts apps/mobile/src/features/home/homeThreadList.test.ts— unrun.vp run check:changed— unrun.Expected order worked out by hand:
archreturnsArch(exact 5.5),Archive(prefix 4),Search(substring 3),Arxh(one edit 2),AxRxCxH(subsequence 1), regardless of the newer typo timestamp.searchreturns titleSearchingbefore projectSearch, branchfeature/search, and message-preview-onlySearchby tier. Equal-scoredSearch threaditems order by descending timestamp, then input index.serach,searxh,searxch, andsarchmatchSearch;cotdoes not fuzzy-matchCat, andsxxrchdoes not matchSearch.How Kevin checks it on his phone
Install an Android build of
feat/mobile-fuzzy-thread-searchusing the maintainer'svp run mobile:install androidworkflow. On Home and the navigation sidebar, searcharchandserach; verify exact/prefix/substring results precede typos, while title/project hits precede message-only hits. Repeat in Archived Threads; clear the query to verify pinned shelves and archived newest/oldest ordering remain unchanged. Physical device verification has not happened.Follow-ups
Open risks: no verified test pass or Android capture; message-only hits have no server relevance score, and archive still groups by project. This review did not change #77 or #78.
Implemented by ChatGPT (mobile app, GitHub connector) for Kevin's OSS factory.