Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Owner O13: “can we setup ai search & fuzzy search and just overall better search algorithm for t3code android. also move the search bar to the bottom and lets think thru how to improve navigation while not adding too much clutter at the bottom since nav bar is there too. generate a few prototypes and fix the search algo first in parallel”
This Draft PR is prototype A only: search placement on Android Home, behind an opt-in setting. Search ranking/fuzzy matching belongs to its parallel card.
Design
primarySidebarSearchQueryas Home, so filtering is unchanged.Change (source at 37ab201)
apps/mobile/src/persistence/mobile-preferences.ts:100— persist/sanitize default-off opt-in.apps/mobile/src/features/settings/appearance/sections/AndroidNavigationAppearanceSection.tsx:39— Bottom search (prototype A) toggle under Settings → Appearance → Navigation.apps/mobile/src/features/workspace/bottom-search-prototype.ts:17— opt-in expanded/collapsed model.apps/mobile/src/features/workspace/bottom-search-prototype-state.ts:3— presentation/state transition logic.apps/mobile/src/features/workspace/WorkspaceTabsContext.tsx:16andWorkspaceRootScreen.android.tsx:42— share the model between Home and navigation.apps/mobile/src/features/home/ThreadListToolbar.android.tsx:73— hide the top field only when enabled; preserve hardware-search shortcut.apps/mobile/src/features/workspace/AndroidWorkspaceNavigation.android.tsx:114— compact pill in the native nav row; expanding search input, Back/close/blur behavior.apps/mobile/src/components/ui/SearchField.tsx:15— optional blur callback for existing search field.apps/mobile/src/features/home/AndroidHomeFab.android.tsx:44— hide FAB while bottom search is expanded.Tests
apps/mobile/src/features/workspace/bottom-search-prototype-state.test.ts:9tests toggle-off/top-search parity, pill→field transition, Back/close, blank/nonblank blur, and disabling the prototype.vp test run apps/mobile/src/features/workspace/bottom-search-prototype-state.test.tsvp run check:changedHow Kevin checks it on his phone
Follow-ups
Known risk: Native navigation width and keyboard placement need on-device verification; connector-only implementation cannot prove tap-target or IME geometry.
Implemented by ChatGPT (mobile app, GitHub connector) for Kevin's OSS factory.