Skip to content

Revert "Revert "userdata: add tests for write_files in containers""#941

Closed
uncleDecart wants to merge 1 commit intomasterfrom
revert-925-revert-918-cloud-config-container-test
Closed

Revert "Revert "userdata: add tests for write_files in containers""#941
uncleDecart wants to merge 1 commit intomasterfrom
revert-925-revert-918-cloud-config-container-test

Conversation

@uncleDecart
Copy link
Copy Markdown
Member

Reverts #925

Since we bumped EVE version cloud-init test should work. This PR reverts the revert of PR :)

image

@giggsoff
Copy link
Copy Markdown
Collaborator

Not sure that it is a blocker, but nice to see green mark of DCO check.

@uncleDecart
Copy link
Copy Markdown
Member Author

Not sure that it is a blocker, but nice to see green mark of DCO check.

Hmmm, I did this automatically, let me try to do some magic locally...

@uncleDecart uncleDecart force-pushed the revert-925-revert-918-cloud-config-container-test branch from d38ecaa to 6779366 Compare January 22, 2024 14:45
@uncleDecart
Copy link
Copy Markdown
Member Author

@europaul I see some error here

@europaul
Copy link
Copy Markdown
Contributor

@europaul I see some error here

Thanks for noticing @uncleDecart . This is off, I'm looking into it

@europaul
Copy link
Copy Markdown
Contributor

let's see how the jobs run here

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@uncleDecart uncleDecart force-pushed the revert-925-revert-918-cloud-config-container-test branch from 6779366 to 30f748a Compare January 24, 2024 12:24
@uncleDecart
Copy link
Copy Markdown
Member Author

force rebased to master. Let's see how it runs

@europaul
Copy link
Copy Markdown
Contributor

@uncleDecart we can probably close this PR since it's now superseded by #945

@uncleDecart uncleDecart deleted the revert-925-revert-918-cloud-config-container-test branch February 7, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants