userdata: add tests for write_files in containers#945
Merged
eriknordmark merged 1 commit intolf-edge:masterfrom Jan 30, 2024
Merged
userdata: add tests for write_files in containers#945eriknordmark merged 1 commit intolf-edge:masterfrom
eriknordmark merged 1 commit intolf-edge:masterfrom
Conversation
giggsoff
reviewed
Jan 24, 2024
Collaborator
giggsoff
left a comment
giggsoff
left a comment
There was a problem hiding this comment.
Please add small comment before your addition or on top of the test that the second case is about write_files to not forget.
Since we added support for write_files in cloud-init configuration for containers - here is a test that will check that functionality, including whether the cloud-init config is reapplied at the containers's reboot Signed-off-by: Paul Gaiduk <paulg@zededa.com>
europaul
force-pushed
the
cloud-config-container-test
branch
from
a251ed2 to
403aacc
Compare
giggsoff
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we added support for write_files in cloud-init configuration for containers - here is a test that will check that functionality, including whether the cloud-init config is reapplied at the containers's reboot
This PR is analogous to #941, but fixes the error code check that we have there.