Skip to content

Conversation

@dmcintyr-akamai
Copy link
Contributor

@dmcintyr-akamai dmcintyr-akamai commented Sep 25, 2025

Description 📝

Smoke tests for Nvidia blackwell GPUs on k8s create page.

  1. verify that the GPU tab is not present if there are no linode types returned from the api
  2. if the kubernetesBlackwellPlans feature flag is enabled, then the GPU table displays the blackwells
  3. disabled feature flag excludes blackwells
  4. in enterprise tier, the blackwells are not displayed, as the GPU tab is not available

Changes 🔄

Added tests to /packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts. I didn't add any tests in this pr that actually test the entire create workflow, just testing the options that are present based on the config.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

How to test 🧪

pnpm run cy:run -s packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dmcintyr-akamai dmcintyr-akamai changed the title M3 10622 nvidia smoke tests test [M3-10622]: Smoke tests for Nvidia blackwell GPUs on k8s create page Sep 25, 2025
@dmcintyr-akamai dmcintyr-akamai marked this pull request as ready for review September 25, 2025 18:54
@dmcintyr-akamai dmcintyr-akamai requested a review from a team as a code owner September 25, 2025 18:54
@dmcintyr-akamai dmcintyr-akamai requested review from cliu-akamai and removed request for a team September 25, 2025 18:54
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmcintyr-akamai, looks good! Posted a quick suggestion to help the LKE-E tests pass when using test accounts that don't have LKE-E enabled, but otherwise these look great 👍

Comment on lines 1953 to 1987
describe('enterprise tier hides GPU tab', () => {
it('enabled feature flag', () => {
mockAppendFeatureFlags({
kubernetesBlackwellPlans: true,
}).as('getFeatureFlags');

cy.visitWithLogin('/kubernetes/create');
cy.wait(['@getFeatureFlags', '@getRegions', '@getLinodeTypes']);

cy.findByText('LKE Enterprise').click();
ui.regionSelect.find().click();
ui.regionSelect.find().clear();
ui.regionSelect.find().type(`${mockRegion.label}{enter}`);
cy.wait('@getRegionAvailability');
// "GPU" tab hidden
ui.tabList.findTabByTitle('GPU').should('not.exist');
});

it('disabled feature flag', () => {
mockAppendFeatureFlags({
kubernetesBlackwellPlans: false,
}).as('getFeatureFlags');

cy.visitWithLogin('/kubernetes/create');
cy.wait(['@getFeatureFlags', '@getRegions', '@getLinodeTypes']);

cy.findByText('LKE Enterprise').click();
ui.regionSelect.find().click();
ui.regionSelect.find().clear();
ui.regionSelect.find().type(`${mockRegion.label}{enter}`);
// "GPU" tab hidden
ui.tabList.findTabByTitle('GPU').should('not.exist');
});
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happened to run this using my Devcloud account by mistake and observed a failure in the 'enterprise tier hides GPU tab -> enabled feature flag' test since I don't have LKE-E enabled on that account. We can fix that for both of these tests and avoid failures in DevCloud by mocking the account to have LKE-E capabilities:

mockGetAccount(accountFactory.build({ capabilities: ['Linodes', 'Kubernetes', 'Kubernetes Enterprise']}));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, done.

@dmcintyr-akamai
Copy link
Contributor Author

added "do not merge" label bc i am experimenting w/ how to get these new tests to pass in devcloud

@dmcintyr-akamai dmcintyr-akamai requested a review from a team as a code owner September 30, 2025 16:56
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 832 passing tests on test run #15 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing832 Passing11 Skipped36m 41s

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Oct 2, 2025
@dmcintyr-akamai dmcintyr-akamai merged commit c0f5458 into linode:develop Oct 2, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Oct 2, 2025
@dmcintyr-akamai dmcintyr-akamai deleted the M3-10622_nvidia_smokeTests branch October 2, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants