-
Notifications
You must be signed in to change notification settings - Fork 391
test [M3-10622]: Smoke tests for Nvidia blackwell GPUs on k8s create page #12917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test [M3-10622]: Smoke tests for Nvidia blackwell GPUs on k8s create page #12917
Conversation
packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts
Outdated
Show resolved
Hide resolved
…ai/manager into M3-10622_nvidia_smokeTests
jdamore-linode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dmcintyr-akamai, looks good! Posted a quick suggestion to help the LKE-E tests pass when using test accounts that don't have LKE-E enabled, but otherwise these look great 👍
| describe('enterprise tier hides GPU tab', () => { | ||
| it('enabled feature flag', () => { | ||
| mockAppendFeatureFlags({ | ||
| kubernetesBlackwellPlans: true, | ||
| }).as('getFeatureFlags'); | ||
|
|
||
| cy.visitWithLogin('/kubernetes/create'); | ||
| cy.wait(['@getFeatureFlags', '@getRegions', '@getLinodeTypes']); | ||
|
|
||
| cy.findByText('LKE Enterprise').click(); | ||
| ui.regionSelect.find().click(); | ||
| ui.regionSelect.find().clear(); | ||
| ui.regionSelect.find().type(`${mockRegion.label}{enter}`); | ||
| cy.wait('@getRegionAvailability'); | ||
| // "GPU" tab hidden | ||
| ui.tabList.findTabByTitle('GPU').should('not.exist'); | ||
| }); | ||
|
|
||
| it('disabled feature flag', () => { | ||
| mockAppendFeatureFlags({ | ||
| kubernetesBlackwellPlans: false, | ||
| }).as('getFeatureFlags'); | ||
|
|
||
| cy.visitWithLogin('/kubernetes/create'); | ||
| cy.wait(['@getFeatureFlags', '@getRegions', '@getLinodeTypes']); | ||
|
|
||
| cy.findByText('LKE Enterprise').click(); | ||
| ui.regionSelect.find().click(); | ||
| ui.regionSelect.find().clear(); | ||
| ui.regionSelect.find().type(`${mockRegion.label}{enter}`); | ||
| // "GPU" tab hidden | ||
| ui.tabList.findTabByTitle('GPU').should('not.exist'); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I happened to run this using my Devcloud account by mistake and observed a failure in the 'enterprise tier hides GPU tab -> enabled feature flag' test since I don't have LKE-E enabled on that account. We can fix that for both of these tests and avoid failures in DevCloud by mocking the account to have LKE-E capabilities:
mockGetAccount(accountFactory.build({ capabilities: ['Linodes', 'Kubernetes', 'Kubernetes Enterprise']}));There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, done.
|
added "do not merge" label bc i am experimenting w/ how to get these new tests to pass in devcloud |
…ai/manager into M3-10622_nvidia_smokeTests
Cloud Manager UI test results🎉 832 passing tests on test run #15 ↗︎
|
Description 📝
Smoke tests for Nvidia blackwell GPUs on k8s create page.
Changes 🔄
Added tests to /packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts. I didn't add any tests in this pr that actually test the entire create workflow, just testing the options that are present based on the config.
Scope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
pnpm run cy:run -s packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅