Skip to content
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12917-tests-1758825978456.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tests
---

Smoke tests for nvidia blackwell gpu plan selection ([#12917](https://github.com/linode/manager/pull/12917))
137 changes: 137 additions & 0 deletions packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
dedicatedTypeFactory,
linodeTypeFactory,
pluralize,
regionAvailabilityFactory,
regionFactory,
} from '@linode/utilities';
import {
Expand Down Expand Up @@ -1850,6 +1851,142 @@
});
});

/*
* Each test provided w/ array of 12 mock linode types. Type excluded if:
- flag enabled and id includes 'blackwell'
- enterprise tier and id includes 'gpu'
* If visible in table, rows are always enabled
*/
describe('smoketest for Nvidia Blackwell GPUs in kubernetes/create page', () => {
const mockRegion = regionFactory.build({
id: 'us-east',
label: 'Newark, NJ',
capabilities: [
'GPU Linodes',
'Linodes',
'Kubernetes',
'Kubernetes Enterprise',
],
});

const mockBlackwellLinodeTypes = new Array(4).fill(null).map((_, index) =>
linodeTypeFactory.build({
id: `g3-gpu-rtxpro6000-blackwell-${index + 1}`,
label: `RTX PRO 6000 Blackwell x${index + 1}`,
class: 'gpu',
})
);
beforeEach(() => {
mockGetRegions([mockRegion]).as('getRegions');

// const mockLinodeTypes = [...mockBlackwellLinodeTypes, ...mockGpuTypes];

Check warning on line 1882 in packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts

View workflow job for this annotation

GitHub Actions / ESLint Review (manager)

[eslint] reported by reviewdog 🐢 Remove this commented out code. Raw Output: {"ruleId":"sonarjs/no-commented-code","severity":1,"message":"Remove this commented out code.","line":1882,"column":5,"nodeType":null,"messageId":"commentedCode","endLine":1882,"endColumn":79,"suggestions":[{"messageId":"commentedCodeFix","fix":{"range":[65485,65559],"text":""},"desc":"Remove this commented out code"}]}

mockGetLinodeTypes(mockBlackwellLinodeTypes).as('getLinodeTypes');
const mockRegionAvailability = mockBlackwellLinodeTypes.map((type) =>
regionAvailabilityFactory.build({
plan: type.label,
available: true,
region: mockRegion.id,
})
);
mockGetRegionAvailability(mockRegion.id, mockRegionAvailability).as(
'getRegionAvailability'
);
});

describe('standard tier', () => {
it('enabled feature flag includes blackwells', function () {
mockAppendFeatureFlags({
kubernetesBlackwellPlans: true,
}).as('getFeatureFlags');
cy.visitWithLogin('/kubernetes/create');
cy.wait(['@getFeatureFlags', '@getRegions', '@getLinodeTypes']);

ui.regionSelect.find().click();
ui.regionSelect.find().clear();
ui.regionSelect.find().type(`${mockRegion.label}{enter}`);
cy.wait('@getRegionAvailability');
// Navigate to "GPU" tab
ui.tabList.findTabByTitle('GPU').scrollIntoView();
ui.tabList.findTabByTitle('GPU').should('be.visible').click();

cy.findByRole('table', {
name: 'List of NVIDIA RTX PRO 6000 Blackwell Server Edition Plans',
}).within(() => {
cy.get('tbody tr')
.should('have.length', 4)
.each((row, index) => {

Check warning on line 1918 in packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts

View workflow job for this annotation

GitHub Actions / ESLint Review (manager)

[eslint] reported by reviewdog 🐢 Refactor this code to not nest functions more than 4 levels deep. Raw Output: {"ruleId":"sonarjs/no-nested-functions","severity":1,"message":"Refactor this code to not nest functions more than 4 levels deep.","line":1918,"column":30,"nodeType":null,"endLine":1918,"endColumn":32}
cy.wrap(row).within(() => {
cy.get('td')
.eq(0)
.within(() => {
cy.findByText(mockBlackwellLinodeTypes[index].label).should(
'be.visible'
);
});
ui.button
.findByTitle('Configure Pool')
.should('be.visible')
.should('be.enabled');
});
});
});
});

it('disabled feature flag excludes blackwells', function () {
mockAppendFeatureFlags({
kubernetesBlackwellPlans: false,
}).as('getFeatureFlags');

cy.visitWithLogin('/kubernetes/create');
cy.wait(['@getFeatureFlags', '@getRegions', '@getLinodeTypes']);

ui.regionSelect.find().click();
ui.regionSelect.find().clear();
ui.regionSelect.find().type(`${mockRegion.label}{enter}`);
cy.wait('@getRegionAvailability');
// Navigate to "GPU" tab
// "GPU" tab hidden
ui.tabList.findTabByTitle('GPU').should('not.exist');
});

describe('enterprise tier hides GPU tab', () => {
it('enabled feature flag', () => {
mockAppendFeatureFlags({
kubernetesBlackwellPlans: true,
}).as('getFeatureFlags');

cy.visitWithLogin('/kubernetes/create');
cy.wait(['@getFeatureFlags', '@getRegions', '@getLinodeTypes']);

cy.findByText('LKE Enterprise').click();
ui.regionSelect.find().click();
ui.regionSelect.find().clear();
ui.regionSelect.find().type(`${mockRegion.label}{enter}`);
cy.wait('@getRegionAvailability');
// "GPU" tab hidden
ui.tabList.findTabByTitle('GPU').should('not.exist');
});

it('disabled feature flag', () => {
mockAppendFeatureFlags({
kubernetesBlackwellPlans: false,
}).as('getFeatureFlags');

cy.visitWithLogin('/kubernetes/create');
cy.wait(['@getFeatureFlags', '@getRegions', '@getLinodeTypes']);

cy.findByText('LKE Enterprise').click();
ui.regionSelect.find().click();
ui.regionSelect.find().clear();
ui.regionSelect.find().type(`${mockRegion.label}{enter}`);
// "GPU" tab hidden
ui.tabList.findTabByTitle('GPU').should('not.exist');
});
});
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happened to run this using my Devcloud account by mistake and observed a failure in the 'enterprise tier hides GPU tab -> enabled feature flag' test since I don't have LKE-E enabled on that account. We can fix that for both of these tests and avoid failures in DevCloud by mocking the account to have LKE-E capabilities:

mockGetAccount(accountFactory.build({ capabilities: ['Linodes', 'Kubernetes', 'Kubernetes Enterprise']}));

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, done.

});

/**
* Returns each plan in an array which is similar to the given plan.
*
Expand Down