[NodeJS Templating] Expose adaptivecards-templating version#7209
Merged
anna-dingler merged 12 commits intomicrosoft:mainfrom Apr 20, 2022
Merged
[NodeJS Templating] Expose adaptivecards-templating version#7209anna-dingler merged 12 commits intomicrosoft:mainfrom
anna-dingler merged 12 commits intomicrosoft:mainfrom
Conversation
|
Hi @anna-dingler. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
licanhua
reviewed
Apr 12, 2022
licanhua
reviewed
Apr 12, 2022
licanhua
reviewed
Apr 12, 2022
licanhua
reviewed
Apr 12, 2022
licanhua
reviewed
Apr 12, 2022
licanhua
reviewed
Apr 12, 2022
licanhua
approved these changes
Apr 13, 2022
Contributor
licanhua
left a comment
There was a problem hiding this comment.
You may update the document late. I don't know how to track it before we release this change
jwoo-msft
requested changes
Apr 19, 2022
beervoley
reviewed
Apr 19, 2022
beervoley
reviewed
Apr 19, 2022
source/nodejs/tests/unit-tests/template-test-resources/version-template.json
Show resolved
Hide resolved
…gler/AdaptiveCards into exposeTemplatingVersion
jwoo-msft
approved these changes
Apr 20, 2022
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…t#7209) * In progress: expose templating version * Expose templating version update * resolve PR comments * add template version unit test * Add unit tests and resolve comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose the
adaptivecards-templatinglibrary version by adding a variable$_acTemplateVersiontoIEvaluationContextandTemplateObjectMemory.$_acTemplateVersionholds a JSON with versioning info.Sample Card
How Verified
Tested manually on AdaptiveCards designer
Microsoft Reviewers: Open in CodeFlow