-
Notifications
You must be signed in to change notification settings - Fork 595
[NodeJS Templating] Expose adaptivecards-templating version #7209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anna-dingler
merged 12 commits into
microsoft:main
from
anna-dingler:exposeTemplatingVersion
Apr 20, 2022
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0a2411e
In progress: expose templating version
anna-dingler 168e526
Merge branch 'main' of https://github.com/anna-dingler/AdaptiveCards …
anna-dingler 5d2b4d6
Expose templating version update
anna-dingler abb8167
resolve PR comments
anna-dingler d1233da
Resolve merge conflicts
anna-dingler 29f4e8e
add template version unit test
anna-dingler 2534385
Merge branch 'microsoft:main' into exposeTemplatingVersion
anna-dingler ad17ff3
Merge https://github.com/anna-dingler/AdaptiveCards into exposeTempla…
anna-dingler c09d5db
Add unit tests and resolve comments
anna-dingler d3bc013
Merge branch 'main' of https://github.com/anna-dingler/AdaptiveCards …
anna-dingler d70a788
Merge branch 'microsoft:main' into exposeTemplatingVersion
anna-dingler fdde76b
Merge branch 'exposeTemplatingVersion' of https://github.com/anna-din…
anna-dingler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
source/nodejs/tests/unit-tests/template-test-resources/version-template.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "type": "AdaptiveCard", | ||
| "version": "1.0", | ||
| "body": [ | ||
| { | ||
| "$when": "${$_acTemplateVersion.major >= 2}", | ||
| "type": "TextBlock", | ||
| "text": "$_acTemplateVersion.major >= 2" | ||
| }, | ||
| { | ||
| "$when": "${$_acTemplateVersion.minor >= 0}", | ||
| "type": "TextBlock", | ||
| "text": "$_acTemplateVersion.minor >= 0" | ||
| }, | ||
| { | ||
| "$when": "${$_acTemplateVersion.patch >= 0}", | ||
| "type": "TextBlock", | ||
| "text": "$_acTemplateVersion.patch >= 0" | ||
| } | ||
|
beervoley marked this conversation as resolved.
|
||
| ] | ||
| } | ||
18 changes: 18 additions & 0 deletions
18
source/nodejs/tests/unit-tests/template-test-resources/version-template.output.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "type": "AdaptiveCard", | ||
| "version": "1.0", | ||
| "body": [ | ||
| { | ||
| "type": "TextBlock", | ||
| "text": "$_acTemplateVersion.major >= 2" | ||
| }, | ||
| { | ||
| "type": "TextBlock", | ||
| "text": "$_acTemplateVersion.minor >= 0" | ||
| }, | ||
| { | ||
| "type": "TextBlock", | ||
| "text": "$_acTemplateVersion.patch >= 0" | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.