Skip to content

test: add more path translation variations #13927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benhillis merged 2 commits into from
Dec 17, 2025
Merged

test: add more path translation variations #13927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e157e6
test: add more path translation variations
Dec 16, 2025
ed20957
Update test/windows/SimpleTests.cpp
benhillis Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/linux/unit_tests/wslpath.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,13 @@ Return Value:
LxtCheckResult(LxtCheckWslPathTranslation("C:/Foo/bar", "/mnt/c/Foo/bar", true));
LxtCheckResult(LxtCheckWslPathTranslation("foo", "foo", true));
LxtCheckResult(LxtCheckWslPathTranslation("foo\\", "foo/", true));
LxtCheckResult(LxtCheckWslPathTranslation("C:\\Program Files\\Git", "/mnt/c/Program Files/Git", true));
LxtCheckResult(LxtCheckWslPathTranslation("C:\\Program Files\\PowerShell\\7", "/mnt/c/Program Files/PowerShell/7", true));
LxtCheckResult(LxtCheckWslPathTranslation("C:\\Program Files (x86)\\Common Files", "/mnt/c/Program Files (x86)/Common Files", true));
LxtCheckResult(LxtCheckWslPathTranslation(
"C:\\Users\\Test User\\AppData\\Local\\Programs\\Microsoft VS Code\\bin",
"/mnt/c/Users/Test User/AppData/Local/Programs/Microsoft VS Code/bin",
true));

ErrorExit:
return Result;
Expand Down Expand Up @@ -241,6 +248,13 @@ Return Value:
LxtCheckResult(LxtCheckWslPathTranslation("/mnt/c/Users", "C:\\Users", false));
LxtCheckResult(LxtCheckWslPathTranslation("/mnt/c/Users/", "C:\\Users\\", false));
LxtCheckResult(LxtCheckWslPathTranslation("/mnt/c/DOESNOTEXIST/", "C:\\DOESNOTEXIST\\", false));
LxtCheckResult(LxtCheckWslPathTranslation("/mnt/c/Program Files/Git", "C:\\Program Files\\Git", false));
LxtCheckResult(LxtCheckWslPathTranslation("/mnt/c/Program Files/PowerShell/7", "C:\\Program Files\\PowerShell\\7", false));
LxtCheckResult(LxtCheckWslPathTranslation("/mnt/c/Program Files (x86)/Common Files", "C:\\Program Files (x86)\\Common Files", false));
LxtCheckResult(LxtCheckWslPathTranslation(
"/mnt/c/Users/Test User/AppData/Local/Programs/Microsoft VS Code/bin",
"C:\\Users\\Test User\\AppData\\Local\\Programs\\Microsoft VS Code\\bin",
false));

ErrorExit:
return Result;
Expand Down
34 changes: 34 additions & 0 deletions test/windows/SimpleTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,5 +262,39 @@ class SimpleTests
std::transform(upperCaseGuidStringWide.begin(), upperCaseGuidStringWide.end(), upperCaseGuidStringWide.begin(), toupper);
VERIFY_ARE_EQUAL(upperCaseGuidStringWide, wsl::shared::string::GuidToString<wchar_t>(guid, wsl::shared::string::GuidToStringFlags::Uppercase));
}

TEST_METHOD(WindowsPathWithSpaces)
{
wil::unique_environstrings_ptr originalPath;
const DWORD pathLength = GetEnvironmentVariableW(L"PATH", nullptr, 0);
if (pathLength > 0)
{
originalPath.reset(static_cast<PWSTR>(HeapAlloc(GetProcessHeap(), 0, pathLength * sizeof(wchar_t))));
THROW_LAST_ERROR_IF_NULL(originalPath.get());
THROW_LAST_ERROR_IF(GetEnvironmentVariableW(L"PATH", originalPath.get(), pathLength) == 0);
}

auto cleanup = wil::scope_exit([&]() {
if (originalPath)
{
THROW_LAST_ERROR_IF(!SetEnvironmentVariableW(L"PATH", originalPath.get()));
}
});

const wchar_t* testPath =
L"C:\\Program Files\\Git\\cmd;"
L"C:\\Program Files\\PowerShell\\7;"
L"C:\\Program Files (x86)\\Common Files;"
L"C:\\Users\\Test User\\AppData\\Local\\Programs\\Microsoft VS Code\\bin";

THROW_LAST_ERROR_IF(!SetEnvironmentVariableW(L"PATH", testPath));

auto [output, _] = LxsstuLaunchWslAndCaptureOutput(L"echo $PATH");

VERIFY_IS_TRUE(output.find(L"/mnt/c/Program Files/Git/cmd") != std::wstring::npos);
VERIFY_IS_TRUE(output.find(L"/mnt/c/Program Files/PowerShell/7") != std::wstring::npos);
VERIFY_IS_TRUE(output.find(L"/mnt/c/Program Files (x86)/Common Files") != std::wstring::npos);
VERIFY_IS_TRUE(output.find(L"/mnt/c/Users/Test User/AppData/Local/Programs/Microsoft VS Code/bin") != std::wstring::npos);
}
};
} // namespace SimpleTests