Conversation
niels9001
changed the title
Jay-o-Way
reviewed
May 9, 2024
Contributor
Jay-o-Way
left a comment
Jay-o-Way
left a comment
There was a problem hiding this comment.
Nice! Few small comments.
Collaborator
|
/azp run |
2 similar comments
Collaborator
|
/azp run |
Collaborator
|
/azp run |
Collaborator
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Author
Aah, great catch! Updated the image! |
Collaborator
|
/azp run |
1 similar comment
Collaborator
|
/azp run |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Jay-o-Way
reviewed
May 19, 2024
Contributor
|
Looks like this isn't pixel-perfect either |
Contributor
|
Padding of 24 in the "lists" is too large; ListView uses 12 |
Merged
few suggestions, as also commented in #1531 feel free to adapt where needed
Jay-o-Way
reviewed
May 20, 2024
Collaborator
|
/azp run |
…UI-Gallery into niels9001/geometry
Collaborator
Author
|
@Jay-o-Way Made some tweaks based on your feedback, I think for the spacing on the lists for spacing / typeramp we are good as its per what the design folks created for us |
Collaborator
|
/azp run |
karkarl
approved these changes
May 20, 2024
karkarl
added a commit
that referenced
this pull request
Jul 15, 2024
## Description - Updated the design guidance menu names to be inline with the docs (e.g. Icons => Iconography, Colors => Color) and sorted alphabetically. - Moved the Card stroke brush on the Stroke colors page to the top, so it's inline with the Card background brush and the control strokes are grouped. - Adding a bit more spacing between the color sections - Left aligned type ramp image on the Typography page - Added a new Geometry page explaining how to use the CornerRadius resources:  - Added a new Spacing page showing a spacing ramp and some common UI examples with redlines:  ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --------- Co-authored-by: Karen Lai <biilai@microsoft.com> Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the design guidance menu names to be inline with the docs (e.g. Icons => Iconography, Colors => Color) and sorted alphabetically.
Moved the Card stroke brush on the Stroke colors page to the top, so it's inline with the Card background brush and the control strokes are grouped.
Adding a bit more spacing between the color sections
Left aligned type ramp image on the Typography page
Added a new Geometry page explaining how to use the CornerRadius resources:
Added a new Spacing page showing a spacing ramp and some common UI examples with redlines:
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes