Design suggestions#1541
Merged
niels9001 merged 1 commit intomicrosoft:niels9001/geometryfrom May 20, 2024
Merged
Conversation
niels9001
requested changes
May 20, 2024
Collaborator
niels9001
left a comment
niels9001
left a comment
There was a problem hiding this comment.
Thanks @Jay-o-Way, great changes! Some small things to fix, and then I'll merge this in!
| </Setter> | ||
| </Style> | ||
| </UserControl.Resources> | ||
| <Grid MinHeight="68" Background="Transparent"> |
Collaborator
There was a problem hiding this comment.
I think we need the padding.
Left (your changes) vs. right (current):
| </Style> | ||
|
|
||
| <Style | ||
| x:Key="GridRowLightStyle" |
Collaborator
There was a problem hiding this comment.
Ah yes, this is good to do.
Should we rename these so they are consistent?
"GridRowCardStyle" and "GridRowLightCardStyle" or something like that?
And should we move these to App.xaml.cs so they can be re-used across these 2 pages?
Contributor
Author
There was a problem hiding this comment.
You mean App.xaml? Sure, do your thing! 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
few suggestions, as also commented in #1531
feel free to adapt where needed