Skip to content

Fix the window cannot be dragged after resetting to system titlebar then reset it back#1788

Merged
niels9001 merged 4 commits intomicrosoft:mainfrom
HO-COOH:fix/revert-default-titlebar-uninteractive
Mar 8, 2025
Merged

Fix the window cannot be dragged after resetting to system titlebar then reset it back#1788
niels9001 merged 4 commits intomicrosoft:mainfrom
HO-COOH:fix/revert-default-titlebar-uninteractive

Conversation

@HO-COOH
Copy link
Copy Markdown
Contributor

@HO-COOH HO-COOH commented Feb 26, 2025

Closes #1783

Description

  1. You never need to set window.SetTitlebar(null) when you have ExtendsContentIntoTitleBar == false
  2. When you click the "Reset to default custom titlebar" button to reset to the default AppWindowTitleBar that have ExtendsContentIntoTitleBar == true, you should not pass it to null.

Motivation and Context

Because it's a bug

How Has This Been Tested?

Manual.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@marcelwgn
Copy link
Copy Markdown
Contributor

/azp run

@niels9001 niels9001 enabled auto-merge (squash) March 8, 2025 19:25
@niels9001
Copy link
Copy Markdown
Collaborator

/azp run

@niels9001 niels9001 merged commit 145a222 into microsoft:main Mar 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The window cannot be dragged after resetting to system titlebar then reset it back

4 participants