Skip to content

Fix the window cannot be dragged after resetting to system titlebar then reset it back #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niels9001 merged 4 commits into from
Mar 8, 2025
Merged

Fix the window cannot be dragged after resetting to system titlebar then reset it back #1788

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e3f40d
Fix the window cannot be dragged after resetting to system titlebar t…
HO-COOH Feb 26, 2025
eb8bfa8
Do not pass null to window.SetTitleBar
HO-COOH Feb 26, 2025
94484a4
Remove redundant titlebar element passing
HO-COOH Feb 27, 2025
34fd68a
Merge branch 'main' into fix/revert-default-titlebar-uninteractive
niels9001 Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions WinUIGallery/Samples/ControlPages/TitleBarPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,13 @@ private void SetTitleBar(UIElement titlebar, bool forceCustomTitlebar = false)
{
titleBarElement.Visibility = Visibility.Visible;
window.ExtendsContentIntoTitleBar = true;
window.SetTitleBar(titlebar);
window.SetTitleBar(titlebar == null? titleBarElement : titlebar);
Comment thread
HO-COOH marked this conversation as resolved.
Outdated
TitleBarHelper.SetCaptionButtonBackgroundColors(window, Colors.Transparent);
}
else
{
titleBarElement.Visibility = Visibility.Collapsed;
window.ExtendsContentIntoTitleBar = false;
window.SetTitleBar(null);
TitleBarHelper.SetCaptionButtonBackgroundColors(window, null);
}
UpdateButtonText();
Expand Down