Fix Narrator silence on PipsPager page navigation#2093
Merged
ayushjai19 merged 6 commits intomainfrom Jan 6, 2026
Merged
Conversation
Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Narrator silence on page navigation
Add screen reader announcements for PipsPager page navigation
Jan 5, 2026
ayushjai19
reviewed
Jan 6, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
…s without visible TextBlock Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Add screen reader announcements for PipsPager page navigation
Fix Narrator silence on PipsPager page navigation
Jan 6, 2026
ayushjai19
reviewed
Jan 6, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
Collaborator
|
/azp run |
marcelwgn
reviewed
Jan 6, 2026
Saharsh979
approved these changes
Jan 6, 2026
…tification ID Co-authored-by: ayushjai19 <244442986+ayushjai19@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
|
/azp run |
marcelwgn
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Narrator announcement for PipsPager page changes
Summary
This PR fixes an accessibility issue where the Narrator screen reader remained silent when users clicked the Next/Previous page buttons on the PipsPager control in the WinUI 3 Gallery app.
Changes Made:
UIHelper.AnnounceActionForAccessibility()to programmatically announce page changes to screen readersPipsPagerPageChangeNotificationId) for better maintainability and to prevent typosTechnical Implementation:
The solution uses
UIHelper.AnnounceActionForAccessibility()which internally callsAutomationPeer.RaiseNotificationEvent()withAutomationNotificationKind.ActionCompleted. This approach follows the pattern used throughout the WinUI Gallery codebase (AppBarButtonPage, BreadcrumbBarPage, ClipboardPage, etc.) for making narrator announcements without requiring visible UI elements.Accessibility Impact:
Users who rely on screen readers will now hear "Page X of Y selected" when navigating through pages using the Next/Previous buttons, meeting MAS 4.2.12 accessibility requirements, without any visible UI changes to the PipsPager control. The enhanced format provides better context by including the total page count.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.