Skip to content

Fix Narrator silence on PipsPager page navigation #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushjai19 merged 6 commits into from
Jan 6, 2026
+15 −1
Merged

Fix Narrator silence on PipsPager page navigation #2093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
efd2727
Initial plan
Copilot Jan 5, 2026
72dce8d
Add Narrator announcement for PipsPager page changes
Copilot Jan 5, 2026
bd7c118
Fix Margin syntax spacing in XAML sample code
Copilot Jan 6, 2026
c2388bc
Use UIHelper.AnnounceActionForAccessibility for narrator announcement…
Copilot Jan 6, 2026
8ed3c72
Revert Margin syntax change in XAML sample code
Copilot Jan 6, 2026
96726a9
Improve narrator announcement with page count and use constant for no…
Copilot Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion WinUIGallery/Samples/ControlPages/PipsPagerPage.xaml
View file
Open in desktop

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@
</controls:ControlExample>
<controls:ControlExample x:Name="Example2" HeaderText="PipsPager with options to change its orientation and button visibility.">
<controls:ControlExample.Example>
<PipsPager x:Name="TestPipsPager2" />
<PipsPager
x:Name="TestPipsPager2"
NumberOfPages="10"
SelectedIndexChanged="TestPipsPager2_SelectedIndexChanged" />
</controls:ControlExample.Example>
<controls:ControlExample.Options>
<StackPanel>
Expand Down
11 changes: 11 additions & 0 deletions WinUIGallery/Samples/ControlPages/PipsPagerPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,14 @@

using Microsoft.UI.Xaml.Controls;
using System.Collections.Generic;
using WinUIGallery.Helpers;

namespace WinUIGallery.ControlPages;

public sealed partial class PipsPagerPage : Page
{
private const string PipsPagerPageChangeNotificationId = "PipsPagerPageChangeNotificationId";

public List<string> Pictures = new List<string>()
{
"ms-appx:///Assets/SampleMedia/LandscapeImage1.jpg",
Expand All @@ -24,6 +27,14 @@ public PipsPagerPage()
this.InitializeComponent();
}

private void TestPipsPager2_SelectedIndexChanged(PipsPager sender, PipsPagerSelectedIndexChangedEventArgs args)
Comment thread
marcelwgn marked this conversation as resolved.
{
int pageNumber = sender.SelectedPageIndex + 1; // Convert 0-based index to 1-based page number
int totalPages = sender.NumberOfPages;
string announcement = $"Page {pageNumber} of {totalPages} selected";
UIHelper.AnnounceActionForAccessibility(sender, announcement, PipsPagerPageChangeNotificationId);
}

private void OrientationComboBox_SelectionChanged(object sender, SelectionChangedEventArgs e)
{
string? orientation = e.AddedItems[0].ToString();
Expand Down