Skip to content

chore(codegen): move action update into the recorder app#36523

Merged
pavelfeldman merged 1 commit into
microsoft:mainfrom
pavelfeldman:codegen_app
Jul 3, 2025
Merged

chore(codegen): move action update into the recorder app#36523
pavelfeldman merged 1 commit into
microsoft:mainfrom
pavelfeldman:codegen_app

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

No description provided.

// When paused, show inspector.
if (this._debugger.isPaused())
Recorder.showInspectorNoReply(this, RecorderApp.factory(this));
await RecorderApp.showInspectorNoReply(this);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await RecorderApp.showInspectorNoReply(this);
RecorderApp.showInspectorNoReply(this);

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [webkit-library] › library/inspector/title.spec.ts:35:5 › should update primary page URL when original primary closes @webkit-ubuntu-22.04-node18

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1087:7 › cli codegen record › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:116:5 › mobile viewport › default mobile viewports to 980 width @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

47079 passed, 980 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit fc0b770 into microsoft:main Jul 3, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants